Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

http2: sessionError vs aborted #28267

Open
ronag opened this issue Jun 17, 2019 · 6 comments
Open

http2: sessionError vs aborted #28267

ronag opened this issue Jun 17, 2019 · 6 comments
Labels
http2 Issues or PRs related to the http2 subsystem.

Comments

@ronag
Copy link
Member

ronag commented Jun 17, 2019 •
edited
Loading

A little confusion regarding the 'sessionError' on http2 servers.

I'm getting a lot of sessionErrors with ECONNRESET. This feels more like clients killing their connections, i.e. aborted rather than an server/session error?

I believe currently we are handling most cases where a incoming connection is unexpectedly closed we emit aborted events rather than error?

Or is there something else that could cause such an error?

Is this a potential bug?
@lpinca lpinca added the http2 Issues or PRs related to the http2 subsystem. label Jul 13, 2019
@gireeshpunathil
Copy link
Member

@nodejs/http2

@antsmartian
Copy link
Contributor

Friendly ping : @nodejs/http2

@apapirovski
Copy link
Contributor

Likely means these clients don’t gracefully terminate their sessions. Unfortunately lack if conformance with the spec is rather common.

@ronag
Copy link
Member Author

ronag commented Jan 8, 2020 •
edited
Loading

Is there are reason why we can't/shouldn't normalize that into 'aborted'? Would potentially make using http2 in NodeJS easier?

@mcollina
Copy link
Member

mcollina commented Jan 9, 2020

I'm +1 in using 'aborted', especially in the compat mode.

@ronag ronag mentioned this issue Jan 16, 2020
Open
32 tasks
@ronag
Copy link
Member Author

ronag commented Apr 19, 2020

@rexagod maybe something you'd like to pick up?

@rexagod rexagod mentioned this issue Apr 20, 2020
Closed
4 tasks
rexagod added a commit to rexagod/node that referenced this issue Apr 22, 2020
@rexagod
http2: emit 'aborted' events instead of 'sessionError'
ca0b8c5 
Fixes: nodejs#28267
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@apapirovski @mcollina @antsmartian @lpinca @ronag @gireeshpunathil