Skip to content

Release proposal: v4.1.0 #2844

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
3 of 7 tasks
Fishrock123 opened this issue Sep 13, 2015 · 12 comments
Closed
3 of 7 tasks

Release proposal: v4.1.0 #2844

Fishrock123 opened this issue Sep 13, 2015 · 12 comments
Labels
meta Issues and PRs related to the general management of the project.

Comments

@Fishrock123
Copy link
Contributor

The usual weekly-ish

That list isn't exactly so exciting, so I'd like to get some important fix-y PRs in beforehand, if possible:

Aiming for tuesday/wednesday. cc @nodejs/release
@Fishrock123 Fishrock123 added the meta Issues and PRs related to the general management of the project. label Sep 13, 2015
@Fishrock123 Fishrock123 changed the title Release proposal v4.0.1 Release proposal: v4.0.1 Sep 13, 2015
Fishrock123 referenced this issue in fishin/ficion Sep 13, 2015
@lloydbenson
do 0.10 now
e10f2fd
@rvagg
Copy link
Member

rvagg commented Sep 14, 2015

node-gyp@3.0.3 just released, it's fairly important to get on top of this even though we just did 3.0.2, my bad

@ronkorving
Copy link
Contributor

If you want something exciting to add, why not add #2167? :)
(I feel like Zoidberg...)

Update: and it landed \o/ (thanks!)

@Fishrock123 Fishrock123 changed the title Release proposal: v4.0.1 Release proposal: v4.1.0 Sep 15, 2015
@Fishrock123
Copy link
Contributor Author

Updated. Now v4.1.0.

@ChALkeR
Copy link
Member

ChALkeR commented Sep 15, 2015

#2824 looks pretty critical, btw. None of unfinished PRs above do. Should the release be delayed?

@Fishrock123
Copy link
Contributor Author

@ChALkeR correct. I'll get this rolling once I get back from lunch.

@indutny
Copy link
Member

indutny commented Sep 15, 2015

Let's hold it for a bit more. I have a CL that should land VERY SOON (tonight): https://codereview.chromium.org/1327403002/ . This a fix for node-ffi problem:

#2791

@Fishrock123 Fishrock123 mentioned this issue Sep 15, 2015
Merged
@rvagg
Copy link
Member

rvagg commented Sep 16, 2015

I'm -1 on waiting for that CL, doesn't look like it's going to land in a timely manner and it can easily make it in to a release next week.

@Fishrock123
Copy link
Contributor Author

Ugh, well, too late now. I'll do the release tomorrow.

Fishrock123 added a commit to Fishrock123/node that referenced this issue Sep 17, 2015
@Fishrock123
2015-09-17, Version 4.1.0 (Stable) Release
b4ec2c2 
Notable changes:

* buffer:
  - Buffers are now created in JavaScript, rather than C++. This increases the speed of buffer creation (Trevor Norris) nodejs#2866.
  - `Buffer#slice()` now uses `Uint8Array#subarray()` internally, increasing `slice()` performance (Karl Skomski) nodejs#2777.
* fs:
  - `fs.utimes()` now properly converts numeric strings, `NaN`, and `Infinity` (Yazhong Liu) nodejs#2387.
  - `fs.WriteStream` now implements `_writev`, allowing for super-fast bulk writes (Ron Korving) nodejs#2167.
* http: Fixed an issue with certain `write()` sizes causing errors when using `http.request()` (Fedor Indutny) nodejs#2824.
* npm: Upgrade to version 2.14.3, see https://github.com/npm/npm/releases/tag/v2.14.3 for more details (Kat Marchán) nodejs#2822.
* src: V8 cpu profiling no longer erroneously shows idle time (Oleksandr Chekhovskyi) nodejs#2324.
* v8: Lateral upgrade to 4.5.103.33 from 4.5.103.30, contains minor fixes (Ali Ijaz Sheikh) nodejs#2870.
  - This fixes a previously known bug where some computed object shorthand properties did not work correctly (nodejs#2507).

Refs: nodejs#2844
PR-URL: nodejs#2889
Fishrock123 added a commit to Fishrock123/node that referenced this issue Sep 17, 2015
@Fishrock123
Working on v4.1.1
8f6f291 
Refs: nodejs#2844
PR-URL: nodejs#2889
@Fishrock123
Copy link
Contributor Author

Building at https://ci.nodejs.org/job/iojs+release/171/

@Fishrock123
Copy link
Contributor Author

... Windows failed to download the ref. Restarted: https://ci.nodejs.org/job/iojs+release/172/

Fishrock123 added a commit that referenced this issue Sep 17, 2015
@Fishrock123 @rvagg
2015-09-17, Version 4.1.0 (Stable) Release
e4f2952 
Notable changes:

* buffer:
  - Buffers are now created in JavaScript, rather than C++. This increases the speed of buffer creation (Trevor Norris) #2866.
  - `Buffer#slice()` now uses `Uint8Array#subarray()` internally, increasing `slice()` performance (Karl Skomski) #2777.
* fs:
  - `fs.utimes()` now properly converts numeric strings, `NaN`, and `Infinity` (Yazhong Liu) #2387.
  - `fs.WriteStream` now implements `_writev`, allowing for super-fast bulk writes (Ron Korving) #2167.
* http: Fixed an issue with certain `write()` sizes causing errors when using `http.request()` (Fedor Indutny) #2824.
* npm: Upgrade to version 2.14.3, see https://github.com/npm/npm/releases/tag/v2.14.3 for more details (Kat Marchán) #2822.
* src: V8 cpu profiling no longer erroneously shows idle time (Oleksandr Chekhovskyi) #2324.
* v8: Lateral upgrade to 4.5.103.33 from 4.5.103.30, contains minor fixes (Ali Ijaz Sheikh) #2870.
  - This fixes a previously known bug where some computed object shorthand properties did not work correctly (#2507).

Refs: #2844
PR-URL: #2889
@vielmetti vielmetti mentioned this issue Sep 17, 2015
Closed
@evanlucas
Copy link
Contributor

With v4.1.0 being out, are we good to close this one?

@rvagg
Copy link
Member

rvagg commented Sep 18, 2015

yes, beware that a 4.1.1 is likely soon due to the zero-fill issue

@rvagg rvagg closed this as completed Sep 18, 2015
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@indutny @ChALkeR @rvagg @ronkorving @evanlucas @Fishrock123