Skip to content

Add napi_buffer_detach() #29674

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
gabrielschulhof opened this issue Sep 23, 2019 · 0 comments
Closed

Add napi_buffer_detach() #29674

gabrielschulhof opened this issue Sep 23, 2019 · 0 comments
Labels
node-api Issues and PRs related to the Node-API.

Comments

@gabrielschulhof
Copy link
Contributor

Per nodejs/node-addon-api#541, and given that detaching a buffer is part of the ES spec, we should likely make this available in a future version of N-API.
@gabrielschulhof gabrielschulhof added the node-api Issues and PRs related to the Node-API. label Sep 23, 2019
@legendecas legendecas mentioned this issue Sep 30, 2019
Closed
4 tasks
legendecas added a commit to legendecas/node that referenced this issue Oct 8, 2019
@legendecas
n-api: add napi_detach_arraybuffer
5134337 
As ArrayBuffer#detach is an ecma spec operation
([Section 24.1.1.3](https://tc39.es/ecma262/#sec-detacharraybuffer)),
it might be good to have it in N-API.

Fixes nodejs#29674
@Trott Trott closed this as completed in 6afed1d Oct 14, 2019
targos pushed a commit that referenced this issue Jan 8, 2020
@legendecas @targos
n-api: add napi_detach_arraybuffer
83e225b 
As ArrayBuffer#detach is an ecma spec operation
([Section 24.1.1.3](https://tc39.es/ecma262/#sec-detacharraybuffer)),
it might be good to have it in N-API.

Fixes #29674

PR-URL: #29768
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
BethGriggs pushed a commit that referenced this issue Feb 6, 2020
@legendecas @BethGriggs
n-api: add napi_detach_arraybuffer
cab905f 
As ArrayBuffer#detach is an ecma spec operation
([Section 24.1.1.3](https://tc39.es/ecma262/#sec-detacharraybuffer)),
it might be good to have it in N-API.

Fixes #29674

PR-URL: #29768
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
@legendecas legendecas mentioned this issue Apr 25, 2020
Closed
legendecas added a commit to legendecas/node that referenced this issue Jul 1, 2020
@legendecas
n-api: add napi_detach_arraybuffer
2243556 
As ArrayBuffer#detach is an ecma spec operation
([Section 24.1.1.3](https://tc39.es/ecma262/#sec-detacharraybuffer)),
it might be good to have it in N-API.

Fixes nodejs#29674

PR-URL: nodejs#29768
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
richardlau pushed a commit that referenced this issue Jul 1, 2020
@legendecas @richardlau
n-api: add napi_detach_arraybuffer
961598b 
As ArrayBuffer#detach is an ecma spec operation
([Section 24.1.1.3](https://tc39.es/ecma262/#sec-detacharraybuffer)),
it might be good to have it in N-API.

Fixes: #29674
PR-URL: #29768
Backport-PR-URL: #33061
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gabriel Schulhof <gabriel.schulhof@intel.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

n-api: add napi_detach_arraybuffer legendecas/node
1 participant
@gabrielschulhof