Skip to content

n-api: add napi_is_detached_arraybuffer() #29955

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
gabrielschulhof opened this issue Oct 13, 2019 · 3 comments
Closed

n-api: add napi_is_detached_arraybuffer() #29955

gabrielschulhof opened this issue Oct 13, 2019 · 3 comments
Labels
node-api Issues and PRs related to the Node-API.

Comments

@gabrielschulhof
Copy link
Contributor

We should add napi_is_detached_arraybuffer() as in https://www.ecma-international.org/ecma-262/9.0/#sec-isdetachedbuffer

cc: @legendecas
@legendecas
Copy link
Member

I'd wonder if a napi_is_detachable_arraybuffer would be more suitable and able to cover more situations. As internal buffers in V8 would not be detachable ( Also in JerryScript, which implements internal arraybuffer with inlined back store), an arraybuffer that has not been detached before would still be not detachable.

@legendecas
Copy link
Member

One might be concerning that is_detachable is not defined in ECMA spec.

@Fishrock123 Fishrock123 added the node-api Issues and PRs related to the Node-API. label Oct 14, 2019
@mhdawson
Copy link
Member

@legendecas agreed, we would like to stick to what is in the ECMA spec in most cases.

alexahdp added a commit to alexahdp/node that referenced this issue Nov 6, 2019
@alexahdp
src: added napi_is_detached_arraybuffer method
c9dd345 
Fixes: nodejs#29955
@alexahdp alexahdp mentioned this issue Nov 6, 2019
Closed
4 tasks
lundibundi added a commit to lundibundi/node that referenced this issue Nov 23, 2019
@lundibundi
n-api: implement napi_is_detached_arraybuffer
5cb8752 
This implements ArrayBuffer#IsDetachedBuffer operation as per ECMAScript
specification Section 24.1.1.2 https://tc39.es/ecma262/#sec-isdetachedbuffer

Closes: nodejs#29955
@lundibundi lundibundi mentioned this issue Nov 23, 2019
Closed
4 tasks
addaleax pushed a commit that referenced this issue Nov 30, 2019
@lundibundi @addaleax
n-api: implement napi_is_detached_arraybuffer
8171cef 
This implements ArrayBuffer#IsDetachedBuffer operation as per ECMAScript
specification Section 24.1.1.2 https://tc39.es/ecma262/#sec-isdetachedbuffer

Closes: #29955

PR-URL: #30613
Fixes: #29955
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@lundibundi lundibundi mentioned this issue Jan 20, 2020
Closed
4 tasks
lundibundi added a commit to lundibundi/node that referenced this issue Jan 20, 2020
@lundibundi
n-api: implement napi_is_detached_arraybuffer
68afe9e 
This implements ArrayBuffer#IsDetachedBuffer operation as per ECMAScript
specification Section 24.1.1.2 https://tc39.es/ecma262/#sec-isdetachedbuffer

Closes: nodejs#29955

Backport-PR-URL: nodejs#31422
PR-URL: nodejs#30613
Fixes: nodejs#29955
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
MylesBorins pushed a commit that referenced this issue Jan 30, 2020
@lundibundi @MylesBorins
n-api: implement napi_is_detached_arraybuffer
ea3d4e8 
This implements ArrayBuffer#IsDetachedBuffer operation as per ECMAScript
specification Section 24.1.1.2 https://tc39.es/ecma262/#sec-isdetachedbuffer

Closes: #29955

Backport-PR-URL: #31422
PR-URL: #30613
Fixes: #29955
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
BethGriggs pushed a commit that referenced this issue Feb 6, 2020
@lundibundi @BethGriggs
n-api: implement napi_is_detached_arraybuffer
b5d42ae 
This implements ArrayBuffer#IsDetachedBuffer operation as per ECMAScript
specification Section 24.1.1.2 https://tc39.es/ecma262/#sec-isdetachedbuffer

Closes: #29955

Backport-PR-URL: #31422
PR-URL: #30613
Fixes: #29955
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
@legendecas legendecas mentioned this issue May 2, 2020
Closed
legendecas pushed a commit to legendecas/node that referenced this issue Jul 1, 2020
@lundibundi @legendecas
n-api: implement napi_is_detached_arraybuffer
8ec28f5 
This implements ArrayBuffer#IsDetachedBuffer operation as per ECMAScript
specification Section 24.1.1.2 https://tc39.es/ecma262/#sec-isdetachedbuffer

Closes: nodejs#29955

PR-URL: nodejs#30613
Fixes: nodejs#29955
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
richardlau pushed a commit that referenced this issue Jul 1, 2020
@lundibundi @richardlau
n-api: implement napi_is_detached_arraybuffer
b744ffd 
This implements ArrayBuffer#IsDetachedBuffer operation as per ECMAScript
specification Section 24.1.1.2 https://tc39.es/ecma262/#sec-isdetachedbuffer

Closes: #29955

PR-URL: #30613
Backport-PR-URL: #33061
Fixes: #29955
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gus Caplan <me@gus.host>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
4 participants
@gabrielschulhof @Fishrock123 @legendecas @mhdawson