-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
Documentation writable stream example confusing order #30759
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
@GrosSacASac i would like to work on this issue. |
Hello @GrosSacASac , i want to ask one query. The 'finish' event is emitted after the stream.end() method has been called, and all data has been flushed to the underlying system. so here i have to change 'after the stream.end()' line also. |
I am not sure what you mean exactly ? You can always make a PR it does not need to be perfect, you can always do follow up commits if something needs to be changed. |
ok |
should be before
https://nodejs.org/api/stream.html#stream_event_finish
The text was updated successfully, but these errors were encountered: