-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Windows fs symlink TypeError on Buffer target value #34514
Comments
Could you share the full stack trace? |
Sure! Added the stack trace from Travis. |
@nodejs/fs |
My guess is that this is the commit that created the issue, since There might also be a similar issue right above it if |
It also affected v12.18.3, please release the patch to v12 too. Thx. |
What steps will reproduce the bug?
On Windows:
How often does it reproduce? Is there a required condition?
Always happens on Windows since 14.5.0, it may be necessary to enable symlink support on Windows (I'm not 100% sure how that all works). Does not happen on Linux or macOS.
What is the expected behavior?
No error, and the symlink should be created. Buffer is listed as a valid target type.
What do you see instead?
Additional information
I created a test repo which is tested via Travis CI.
On a side-note, the
path
argument can be a Buffer, it's just thetarget
argument with the issue.The text was updated successfully, but these errors were encountered: