-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
investigate flaky test-vm-timeout-escape-promise-module-2 on freebsd #36627
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
https://ci.nodejs.org/job/node-test-commit-freebsd/38718/nodes=freebsd11-x64/console
|
My local results suggest that parallelism may help rather than hurt this test but I want to confirm that on CI, because that's counterintuitive, especially when FreeBSD in CI has a history of being our most parallel-sensitive platform (probably having to do with the way the CI host counts processors). Stress test with no parallelism: https://ci.nodejs.org/job/node-stress-single-test/231/ Stress test with parallelism: https://ci.nodejs.org/job/node-stress-single-test/232/ |
Results sort of show it's flaky with parallelism and reliable without it, but I imagine the p value is small. 0 failures in 1000 runs in the first case, and 2 failures in 1000 runs in the second place. Let's try them both again with 10000 runs to get a little more confidence: Not parallel: https://ci.nodejs.org/job/node-stress-single-test/233/ |
Test is reliable in sequential and not in parallel, so move it there. Fixes: nodejs#36627
Optimistically opened a PR moving it to sequential. #37842 |
Test is reliable in sequential and not in parallel, so move it there. Fixes: #36627 PR-URL: #37842 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Test is reliable in sequential and not in parallel, so move it there. Fixes: #36627 PR-URL: #37842 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
The text was updated successfully, but these errors were encountered: