-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
Allow 'data' argument on callback of Transform._flush() #3707
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Labels
feature request
Issues that request new features to be added to Node.js.
stream
Issues and PRs related to the stream subsystem.
Comments
I've done a pull-request for this. |
Any update on this? |
piranna
added a commit
to piranna/node
that referenced
this issue
Jun 7, 2016
Add a `data` argument on Transform._flush() callback to be API consistent with Transform._transform(). Fixes: nodejs#3707
Thank you :-) |
This was referenced Mar 29, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
feature request
Issues that request new features to be added to Node.js.
stream
Issues and PRs related to the stream subsystem.
According to the docs,
transform._transform(chunk, encoding, callback)
callback accept optionals error and data chunk:but the callback of
transform._flush(callback)
only accept an optional error. According to the code it would be fairly easy to add.The text was updated successfully, but these errors were encountered: