-
Notifications
You must be signed in to change notification settings - Fork 31.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
stream.pipeline does not accept 'Buffer' as a valid first argument, even though it is an Iterable #37731
Labels
stream
Issues and PRs related to the stream subsystem.
Comments
Linkgoron
added a commit
to Linkgoron/node
that referenced
this issue
Mar 13, 2021
change isStream to also check existence of on, so it wont mistake buffers as Streams. fixes: nodejs#37731
Linkgoron
added a commit
to Linkgoron/node
that referenced
this issue
Mar 13, 2021
change isStream to also check existence of on, so it wont mistake buffers as Streams. fixes: nodejs#37731
Linkgoron
added a commit
to Linkgoron/node
that referenced
this issue
Mar 16, 2021
change isStream to also check existence of on, so it wont mistake buffers as Streams. fixes: nodejs#37731
ruyadorno
pushed a commit
that referenced
this issue
Mar 24, 2021
change isStream to also check existence of on, so it wont mistake buffers as Streams. fixes: #37731 PR-URL: #37739 Fixes: #37731 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this issue
Sep 4, 2021
change isStream to also check existence of on, so it wont mistake buffers as Streams. fixes: #37731 PR-URL: #37739 Fixes: #37731 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
What steps will reproduce the bug?
This issue is a continuation of #36437. Although Iterables are now supported, Buffer (which is an Iterable) is not.
How often does it reproduce? Is there a required condition?
Reproduces in all versions of Node tested, 14.15.5+.
What is the expected behavior?
For Buffer to be able to be used as a source/first argument. Note if
Buffer.from('abc')
is changed toBuffer.from('abc').values()
, it behaves correctly.What do you see instead?
Additional information
The text was updated successfully, but these errors were encountered: