-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
investigate flaky test-policy-integrity #38088
Comments
@bmeck Any idea what might be happening to cause this? |
07:01:15 exit code: 1 signal: null
07:01:15 stdout:
07:01:15 stderr: it is highly suspicious that a process would exit without any output and exit code 1. This means the outer process died after seeing the worker die:
Likely we should change this harness to output the worker stdout/stderr in this case, but I don't see why parent/dep would die this many permutations down. |
It happened again today, and it was again on centos7-arm64-gcc8 and basically all the same symptoms I think:
https://ci.nodejs.org/job/node-test-commit-arm/36974/nodes=centos7-arm64-gcc8/console |
making PR to dump stderr, same permutation number is suspicious |
Did that PR land? Here's another one that happened just now: https://ci.nodejs.org/job/node-test-commit-arm/37067/nodes=centos7-arm64-gcc8/console
|
@Trott local repro shows stderr being logged, got stuff in work stuff this week and cannot find a local repro so it is taking a while. The stuff I have is on #38278 but it should basically act like how worker_threads do normally as documented (though variety of docs seem a bit unclear on timing of events). |
AFAICT the test is failing on
I've logged into
|
Test build on master on |
Although #35633 looks like it should already have caught the case of a |
Maybe a symlink or mount point somehow results in a difference in the way parent directories are detected? |
After further investigation it looks like the existing check is done for directories above the directory containing the test, but the test is actually staging in the test's |
Policy tests can fail if a `package.json` exists in any of the parent directories above the test. The existing checks are done for the ancestors of the test directory but some tests execute from the tmpdir. PR-URL: #38285 Refs: #38088 Refs: #35600 Refs: #35633 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Policy tests can fail if a `package.json` exists in any of the parent directories above the test. The existing checks are done for the ancestors of the test directory but some tests execute from the tmpdir. PR-URL: #38285 Refs: #38088 Refs: #35600 Refs: #35633 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Policy tests can fail if a `package.json` exists in any of the parent directories above the test. The existing checks are done for the ancestors of the test directory but some tests execute from the tmpdir. PR-URL: #38285 Refs: #38088 Refs: #35600 Refs: #35633 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Policy tests can fail if a `package.json` exists in any of the parent directories above the test. The existing checks are done for the ancestors of the test directory but some tests execute from the tmpdir. PR-URL: #38285 Refs: #38088 Refs: #35600 Refs: #35633 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Policy tests can fail if a `package.json` exists in any of the parent directories above the test. The existing checks are done for the ancestors of the test directory but some tests execute from the tmpdir. PR-URL: #38285 Refs: #38088 Refs: #35600 Refs: #35633 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
The test spawns 1302 child processes (1 for each permutation), so I'm not really surprised that it can take a long time to run in CI. It takes 1 minute on my computer (Core i5-4670, 3.40 GHz). |
Maybe we can/should split it into three tests? Like, maybe one for |
Split the test into three tests so that it doesn't time out. Fixes: nodejs#40694 Fixes: nodejs#38088
Split the test into three tests so that it doesn't time out. Fixes: nodejs#40694 Fixes: nodejs#38088
Split the test into seven tests so that it doesn't time out. Fixes: nodejs#40694 Fixes: nodejs#38088
The text was updated successfully, but these errors were encountered: