-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
http_server handles headersTimeout and requestTimeout checking wrong #43355
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Labels
http
Issues or PRs related to the http subsystem.
Comments
nodejs-github-bot
pushed a commit
that referenced
this issue
Dec 24, 2022
Co-authored-by: Luigi Pinca <luigipinca@gmail.com> PR-URL: #45778 Fixes: #43355 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos
pushed a commit
that referenced
this issue
Jan 1, 2023
Co-authored-by: Luigi Pinca <luigipinca@gmail.com> PR-URL: #45778 Fixes: #43355 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS
pushed a commit
that referenced
this issue
Jan 4, 2023
Co-authored-by: Luigi Pinca <luigipinca@gmail.com> PR-URL: #45778 Fixes: #43355 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
RafaelGSS
pushed a commit
that referenced
this issue
Jan 5, 2023
Co-authored-by: Luigi Pinca <luigipinca@gmail.com> PR-URL: #45778 Fixes: #43355 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
juanarbol
pushed a commit
that referenced
this issue
Jan 26, 2023
Co-authored-by: Luigi Pinca <luigipinca@gmail.com> PR-URL: #45778 Fixes: #43355 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
juanarbol
pushed a commit
that referenced
this issue
Jan 31, 2023
Co-authored-by: Luigi Pinca <luigipinca@gmail.com> PR-URL: #45778 Fixes: #43355 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Version
master
Platform
any
Subsystem
http
What steps will reproduce the bug?
Attempt to create http.createServer with options that include requestTimeout and headersTimeout that are set the same and > 0
How often does it reproduce? Is there a required condition?
When creating http server with requestTimeout and headersTimeout set appropriately.
What is the expected behavior?
http server creation should succeed
What do you see instead?
Additional information
#43354
The text was updated successfully, but these errors were encountered: