Skip to content

Compiler warning in src/heap_utils.cc #43577

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
targos opened this issue Jun 26, 2022 · 1 comment · Fixed by #43579
Closed

Compiler warning in src/heap_utils.cc #43577

targos opened this issue Jun 26, 2022 · 1 comment · Fixed by #43579
Labels
build Issues and PRs related to build files or the CI.

Comments

@targos
Copy link
Member

targos commented Jun 26, 2022

[2349/3775] CXX obj/src/libnode.heap_utils.o
../../src/heap_utils.cc:248:7: warning: comparison of integers of different signs: 'const int' and 'const size_t' (aka 'const unsigned long') [-Wsign-compare]
      DCHECK_LE(num_bytes_written, buf.len);
      ^         ~~~~~~~~~~~~~~~~~  ~~~~~~~
../../src/util.h:173:37: note: expanded from macro 'DCHECK_LE'
  #define DCHECK_LE(a, b) CHECK((a) <= (b))
                                 ~  ^   ~
../../src/util.h:153:20: note: expanded from macro 'CHECK'
    if (UNLIKELY(!(expr))) {                                                  \
                   ^~~~
../../src/util.h:140:44: note: expanded from macro 'UNLIKELY'
#define UNLIKELY(expr) __builtin_expect(!!(expr), 0)
                                           ^~~~
1 warning generated.
RaisinTen added a commit to RaisinTen/node that referenced this issue Jun 26, 2022
Fixes: nodejs#43577
Signed-off-by: Darshan Sen <raisinten@gmail.com>
@RaisinTen
Copy link
Member

Here's a fix - #43579

@F3n67u F3n67u added the build Issues and PRs related to build files or the CI. label Jun 27, 2022
nodejs-github-bot pushed a commit that referenced this issue Jun 29, 2022
Fixes: #43577
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #43579
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
mabaasit pushed a commit to mabaasit/node that referenced this issue Jul 6, 2022
Fixes: nodejs#43577
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: nodejs#43579
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
targos pushed a commit that referenced this issue Jul 12, 2022
Fixes: #43577
Signed-off-by: Darshan Sen <raisinten@gmail.com>

PR-URL: #43579
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
build Issues and PRs related to build files or the CI.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants