-
-
Notifications
You must be signed in to change notification settings - Fork 31.6k
Testrunner glob parsing seems to be broken #43675
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
Hi @jtuchel, |
There was no conclusion that I'm aware of. I think we should implement a CLI flag for this functionality based on regular expressions instead of globs. If/when Node adds glob support, we could switch over to using that (or stick with regular expressions if they are working well). |
PR-URL: nodejs#44241 Fixes: nodejs#44023 Fixes: nodejs#43675 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs#44241 Backport-PR-URL: nodejs#TBD Fixes: nodejs#44023 Fixes: nodejs#43675 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs#44241 Backport-PR-URL: nodejs#44873 Fixes: nodejs#44023 Fixes: nodejs#43675 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs#44241 Backport-PR-URL: nodejs#44873 Fixes: nodejs#44023 Fixes: nodejs#43675 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs#44241 Backport-PR-URL: nodejs#44873 Fixes: nodejs#44023 Fixes: nodejs#43675 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs#44241 Backport-PR-URL: nodejs#44873 Fixes: nodejs#44023 Fixes: nodejs#43675 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs#44241 Backport-PR-URL: nodejs#44873 Fixes: nodejs#44023 Fixes: nodejs#43675 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs#44241 Backport-PR-URL: nodejs#44873 Fixes: nodejs#44023 Fixes: nodejs#43675 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs/node#44241 Backport-PR-URL: nodejs/node#44873 Fixes: nodejs/node#44023 Fixes: nodejs/node#43675 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs/node#44241 Backport-PR-URL: nodejs/node#44873 Fixes: nodejs/node#44023 Fixes: nodejs/node#43675 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
PR-URL: nodejs/node#44241 Fixes: nodejs/node#44023 Fixes: nodejs/node#43675 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> (cherry picked from commit 59527de13d39327eb3dfa8dedc92241eb40066d5)
PR-URL: nodejs/node#44241 Fixes: nodejs/node#44023 Fixes: nodejs/node#43675 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> (cherry picked from commit 59527de13d39327eb3dfa8dedc92241eb40066d5)
PR-URL: nodejs/node#44241 Fixes: nodejs/node#44023 Fixes: nodejs/node#43675 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> (cherry picked from commit 59527de13d39327eb3dfa8dedc92241eb40066d5)
Version
18.4.0
Platform
Linux pop-os 5.17.15-76051715-generic #202206141358
165591911622.04~1db9e34 SMP PREEMPT Wed Jun 22 19 x86_64 x86_64 x86_64 GNU/LinuxSubsystem
No response
What steps will reproduce the bug?
npm init -y
"test": "node --test ./myTestDir/**/*Tests.js"
pickedUpTests.js
ignoredTests.js
npm run test
only pickedUpTests runHow often does it reproduce? Is there a required condition?
Always
What is the expected behavior?
It should run all tests ( failing ones too )
What do you see instead?
It seems the glob parsing is broken so it only runs tests on a specific directory depth
Additional information
A temporary workaround for this would be the glob
./myTestDir/**/**/*Tests.js
The text was updated successfully, but these errors were encountered: