Skip to content

test-worker-heap-snapshot crash #44515

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
ywave620 opened this issue Sep 5, 2022 · 1 comment · Fixed by #44745
Closed

test-worker-heap-snapshot crash #44515

ywave620 opened this issue Sep 5, 2022 · 1 comment · Fixed by #44745
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. windows Issues and PRs related to the Windows platform.

Comments

@ywave620
Copy link
Contributor

ywave620 commented Sep 5, 2022

Test

test-worker-heap-snapshot

Platform

win2012r2-COMPILED_BY-vs2019-x86

Console output

16:35:12 not ok 799 parallel/test-worker-heap-snapshot
16:35:12   ---
16:35:12   duration_ms: 1.258
16:35:12   severity: fail
16:35:12   exitcode: 134
16:35:12   stack: |-
16:35:12     FATAL ERROR: HandleScope::HandleScope Entering the V8 API without proper locking in place
16:35:12   ...

Build links

Additional information

failed on CI of this PR: #44434
The test failed on another CI, either: #39686

@ywave620 ywave620 added the flaky-test Issues and PRs related to the tests with unstable failures on the CI. label Sep 5, 2022
@github-actions github-actions bot added the windows Issues and PRs related to the Windows platform. label Sep 5, 2022
@joyeecheung
Copy link
Member

Truncated stack trace from an old report: nodejs/reliability#338

not ok 3188 parallel/test-worker-heap-snapshot
  ---
  duration_ms: 1.253
  severity: crashed
  exitcode: -6
  stack: |-
    FATAL ERROR: HandleScope::HandleScope Entering the V8 API without proper locking in place
     1: 13c3bde node::Abort() [/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos20-64/out/Release/node]
     2: 13c6fbf node::FatalError(char const*, char const*) [/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos20-64/out/Release/node]
     3: 15e599a v8::Utils::ReportApiFailure(char const*, char const*) [/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos20-64/out/Release/node]
     4: 15e711c v8::HandleScope::HandleScope(v8::Isolate*) [/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos20-64/out/Release/node]
     5: 133f074 node::BaseObject::~BaseObject() [/home/iojs/build/workspace/node-test-commit-smartos/nodes/smartos20-64/out/Release/node]
     6: 130c321 node::AsyncWrap::~AsyncWrap() [/home/iojs/build/workspace/node-test-commit-sm...

nodejs-github-bot pushed a commit that referenced this issue Oct 6, 2022
Any WorkerHeapSnapshotTaker instance should be fully owned
by main thread. Remove buggy access to it from the worker thread.

PR-URL: #44745
Fixes: #44515
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
danielleadams pushed a commit that referenced this issue Oct 11, 2022
Any WorkerHeapSnapshotTaker instance should be fully owned
by main thread. Remove buggy access to it from the worker thread.

PR-URL: #44745
Fixes: #44515
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
flaky-test Issues and PRs related to the tests with unstable failures on the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants