Skip to content

web streams have no Symbol.toStringTag on their prototypes #45114

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
KhafraDev opened this issue Oct 21, 2022 · 2 comments
Closed

web streams have no Symbol.toStringTag on their prototypes #45114

KhafraDev opened this issue Oct 21, 2022 · 2 comments
Labels
web streams

Comments

@KhafraDev
Copy link
Member

KhafraDev commented Oct 21, 2022 •
edited
Loading

Version

v18.11.0

Platform

Microsoft Windows NT 10.0.19043.0 x64

Subsystem

No response

What steps will reproduce the bug?

console.log(ReadableStream.prototype[Symbol.toStringTag])
console.log(WritableStream.prototype[Symbol.toStringTag])
console.log(TransformStream.prototype[Symbol.toStringTag])

How often does it reproduce? Is there a required condition?

No response

What is the expected behavior?

to log ReadableStream, WritableStream, TransformStream

What do you see instead?

undefined

Additional information

No response
@KhafraDev KhafraDev changed the title web ReadableStream has no Symbol.toStringTag on its prototype web streams have no Symbol.toStringTag on their prototypes Oct 21, 2022
MrJithil added a commit to MrJithil/node that referenced this issue Oct 22, 2022
@MrJithil
webstreams: fix web streams have no Symbol.toStringTag
958a787 
fix web streams have no Symbol.toStringTag
nodejs#45114
@MrJithil MrJithil mentioned this issue Oct 22, 2022
Merged
@MrJithil
Copy link
Member

Fixing PR #45117

@aduh95 aduh95 mentioned this issue Oct 23, 2022
Closed
@MrJithil MrJithil mentioned this issue Oct 25, 2022
Merged
@aduh95
Copy link
Contributor

aduh95 commented Oct 26, 2022

Fixed by e9ba08e

@aduh95 aduh95 closed this as completed Oct 26, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
web streams
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

stream: align @@toStringTag with other Web Streams implementations aduh95/node
4 participants
@aduh95 @MrJithil @KhafraDev @VoltrexKeyva