Enable C++20 #45402

targos · 2022-11-10T08:21:59Z

Chromium is making the move: https://bugs.chromium.org/p/chromium/issues/detail?id=1284275 / https://chromium-review.googlesource.com/c/chromium/src/+/3946562

Is it something we want to do too?

/cc @nodejs/cpp-reviewers

gengjiawen · 2022-11-10T09:27:26Z

+1 from me. I like newer cpp features .

RafaelGSS · 2022-11-10T12:12:51Z

+1 from me too.

mhdawson · 2022-11-10T17:27:04Z

@targos can we do that without bumping our compiler versions?

gengjiawen · 2022-11-11T01:28:27Z

@targos can we do that without bumping our compiler versions?

we are currently using GCC 8.3, From https://en.cppreference.com/w/cpp/compiler_support#cpp20,
Gcc 10 likely the version we need to upgrade.

Also if v8 follows chromium decision, we have no choice but upgrade our toolchain.

targos · 2022-11-11T11:03:00Z

Maybe our current compiler versions are enough. They all have some level of partial support of C++20.

Closes: nodejs#45402

targos · 2022-11-11T11:18:22Z

I'm trying to build locally with targos@0065fd6

tniessen · 2022-11-11T11:58:40Z

I'd like to see this happen. Related: #44411 (comment)

jasnell · 2022-11-11T12:10:35Z

Yes please

targos · 2022-11-11T12:30:50Z

I created a draft PR: #45427 Feel free to push fixes to it.

gengjiawen · 2022-11-19T09:41:04Z

Not sure v8 can goes modules, if it goes. really look forward to build time performance.

dharesign · 2022-12-01T13:19:58Z

As noted in #45694, we need a fix for CppHeapCreateParams as well. Please see the detail there.

targos · 2022-12-01T13:34:29Z

Let's try to revert the problematic commit: #45700

Edit: it breaks the MSVC build.

dharesign · 2022-12-13T17:07:53Z

OK, I figured out why it's breaking: it's because the CppHeapCreateParams struct is dllexport, which seems to cause it to fully instantiate the vector<> class, including parts that don't work.

Can reproduce: https://godbolt.org/z/8Wah9KbP3

Note that the error points to line 9 as the place the class is being instantiated, even though it's line 16 that's really causing it.

dharesign · 2022-12-13T17:32:10Z

Relevant: https://devblogs.microsoft.com/oldnewthing/20190927-00/?p=102932

dharesign · 2022-12-13T17:48:49Z

So unique_ptr<T> is not is_copy_constructible, but vector<unique_ptr<T>> is. It seems that this is a deliberate design choice that enables vector to be instantiated with incomplete types.

The only way to then export such a non-copyable class is to have the copy constructors explicitly deleted.

Doing that breaks the C++20 aggregate initialization per https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2018/p1008r1.pdf

I guess the most reasonable way forward is probably to give CppHeapCreateParams real constructors and not rely on aggregate initialization.

Thoughts @mlippautz?

anonrig · 2023-01-10T20:54:35Z

While I'm working on Ada, I am currently bounded by C++17 due to the possibility for being a suitable candidate for Node. Some nice features are coming with C++20, and I wanted to learn the current progress, timeline, and missing things required to make this change. I'd be happy to help.

gengjiawen · 2023-01-11T02:16:16Z

wanted to learn the current progress

see #45427. Mainly blocked by MSVC.

targos · 2023-01-11T08:14:46Z

I'll check the status of MSVC after #46125

gengjiawen · 2023-02-02T09:29:18Z

Upstream issue in v8: https://crbug.com/1377771

Closes: nodejs#45402

targos · 2023-11-14T08:34:47Z

Chromium now officially supports C++20: https://chromium-review.googlesource.com/c/chromium/src/+/4217486

This is unfortunately still blocked on nodejs/build#3317

Closes: nodejs#45402

Our Linux build infra is not ready for it yet, but V8 is making it difficult to compile on Windows without it. Refs: #45402

Our Linux build infra is not ready for it yet, but V8 is making it difficult to compile on Windows without it. Refs: nodejs#45402

Our Linux build infra is not ready for it yet, but V8 is making it difficult to compile on Windows without it. Refs: #45402 PR-URL: #52465 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

Closes: nodejs#45402

Closes: nodejs#45402 PR-URL: nodejs#45427 Fixes: nodejs#45402 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Steven R Loomis <srl295@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>

Our Linux build infra is not ready for it yet, but V8 is making it difficult to compile on Windows without it. Refs: nodejs#45402 PR-URL: nodejs#52465 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com>

Closes: nodejs#45402 PR-URL: nodejs#45427 Fixes: nodejs#45402 Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Steven R Loomis <srl295@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Ulises Gascón <ulisesgascongonzalez@gmail.com>

targos added the build Issues and PRs related to build files or the CI. label Nov 10, 2022

targos added a commit to targos/node that referenced this issue Nov 11, 2022

build: compile with C++20 support

0065fd6

Closes: nodejs#45402

This comment was marked as duplicate.

# to view

targos mentioned this issue Nov 11, 2022

build: compile with C++20 support #45427

Merged

gengjiawen mentioned this issue Nov 19, 2022

build: fix env.h for cpp20 #45516

Merged

aduh95 mentioned this issue Dec 1, 2022

Can't Build With C++20 #45694

Closed

targos mentioned this issue Dec 1, 2022

deps: V8: add explicit constructor to CppHeapCreateParams #45700

Closed

richardlau mentioned this issue Feb 23, 2023

build: warn for gcc versions earlier than 10.1 #46806

Merged

targos added a commit to targos/node that referenced this issue Mar 30, 2023

build: compile with C++20 support

549f935

Closes: nodejs#45402

targos added a commit to targos/node that referenced this issue Mar 31, 2023

build: compile with C++20 support

1f04009

Closes: nodejs#45402

targos added a commit to targos/node that referenced this issue Apr 20, 2023

build: compile with C++20 support

2f13223

Closes: nodejs#45402

targos added a commit to targos/node that referenced this issue May 5, 2023

build: compile with C++20 support

d0a76da

Closes: nodejs#45402

targos added a commit to targos/node that referenced this issue May 22, 2023

build: compile with C++20 support

7638d49

Closes: nodejs#45402

targos added a commit to targos/node that referenced this issue Jun 12, 2023

build: compile with C++20 support

2909ca7

Closes: nodejs#45402

targos added a commit to targos/node that referenced this issue Aug 2, 2023

build: compile with C++20 support

26ac9e0

Closes: nodejs#45402

targos added a commit to targos/node that referenced this issue Sep 5, 2023

build: compile with C++20 support

6829420

Closes: nodejs#45402

targos added a commit to targos/node that referenced this issue Sep 20, 2023

build: compile with C++20 support

2659cbb

Closes: nodejs#45402

targos added a commit to targos/node that referenced this issue Sep 27, 2023

build: compile with C++20 support

3b02b1b

Closes: nodejs#45402

targos added a commit to targos/node that referenced this issue Dec 10, 2023

build: compile with C++20 support

91e97cc

Closes: nodejs#45402

targos added a commit to targos/node that referenced this issue Dec 11, 2023

build: compile with C++20 support

cc18fc4

Closes: nodejs#45402

targos added a commit to targos/node that referenced this issue Jan 1, 2024

build: compile with C++20 support

e783c94

Closes: nodejs#45402

targos added a commit to targos/node that referenced this issue Jan 8, 2024

build: compile with C++20 support

b5d4cca

Closes: nodejs#45402

targos added a commit to targos/node that referenced this issue Mar 15, 2024

build: compile with C++20 support

62275a3

Closes: nodejs#45402

targos added a commit that referenced this issue Apr 19, 2024

build: compile with C++20 support on Windows

c1cc89d

Our Linux build infra is not ready for it yet, but V8 is making it difficult to compile on Windows without it. Refs: #45402

targos mentioned this issue Apr 19, 2024

build: compile with C++20 support on Windows #52594

Closed

StefanStojanovic added a commit to JaneaSystems/node that referenced this issue Apr 19, 2024

build: compile with C++20 support on Windows

afb9fbf

Our Linux build infra is not ready for it yet, but V8 is making it difficult to compile on Windows without it. Refs: nodejs#45402

StefanStojanovic added a commit to JaneaSystems/node that referenced this issue Apr 21, 2024

build: compile with C++20 support on Windows

2841d12

Our Linux build infra is not ready for it yet, but V8 is making it difficult to compile on Windows without it. Refs: nodejs#45402

targos pushed a commit to targos/node that referenced this issue Apr 21, 2024

build: compile with C++20 support on Windows

dc1a652

Our Linux build infra is not ready for it yet, but V8 is making it difficult to compile on Windows without it. Refs: nodejs#45402

targos pushed a commit to targos/node that referenced this issue Apr 22, 2024

build: compile with C++20 support on Windows

486bbc8

Our Linux build infra is not ready for it yet, but V8 is making it difficult to compile on Windows without it. Refs: nodejs#45402

targos added a commit to targos/node that referenced this issue May 3, 2024

build: compile with C++20 support

43a222a

Closes: nodejs#45402

targos mentioned this issue May 3, 2024

build: compile with C++20 support when using Clang #52819

Closed

nodejs-github-bot closed this as completed in c7e4209 May 5, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Enable C++20 #45402

Enable C++20 #45402

targos commented Nov 10, 2022

gengjiawen commented Nov 10, 2022

RafaelGSS commented Nov 10, 2022

mhdawson commented Nov 10, 2022

gengjiawen commented Nov 11, 2022

targos commented Nov 11, 2022

targos commented Nov 11, 2022

This comment was marked as duplicate.

tniessen commented Nov 11, 2022

jasnell commented Nov 11, 2022

This comment was marked as duplicate.

targos commented Nov 11, 2022

gengjiawen commented Nov 19, 2022

dharesign commented Dec 1, 2022

targos commented Dec 1, 2022 •

edited

Loading

dharesign commented Dec 13, 2022

dharesign commented Dec 13, 2022

dharesign commented Dec 13, 2022

anonrig commented Jan 10, 2023

gengjiawen commented Jan 11, 2023

targos commented Jan 11, 2023

gengjiawen commented Feb 2, 2023

targos commented Nov 14, 2023

Enable C++20 #45402

Enable C++20 #45402

Comments

targos commented Nov 10, 2022

gengjiawen commented Nov 10, 2022

RafaelGSS commented Nov 10, 2022

mhdawson commented Nov 10, 2022

gengjiawen commented Nov 11, 2022

targos commented Nov 11, 2022

targos commented Nov 11, 2022

This comment was marked as duplicate.

tniessen commented Nov 11, 2022

jasnell commented Nov 11, 2022

This comment was marked as duplicate.

targos commented Nov 11, 2022

gengjiawen commented Nov 19, 2022

dharesign commented Dec 1, 2022

targos commented Dec 1, 2022 • edited Loading

dharesign commented Dec 13, 2022

dharesign commented Dec 13, 2022

dharesign commented Dec 13, 2022

anonrig commented Jan 10, 2023

gengjiawen commented Jan 11, 2023

targos commented Jan 11, 2023

gengjiawen commented Feb 2, 2023

targos commented Nov 14, 2023

targos commented Dec 1, 2022 •

edited

Loading