-
-
Notifications
You must be signed in to change notification settings - Fork 31.4k
Add test.todo
to match it.todo
in node:test
#47897
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
CC @cjihrig - this does not exist mainly due to your objection so the API would remain simple. do you still object to this change? |
I do still want the API to remain simple - even small changes add up. I also think this API exactly duplicates existing functionality so it doesn't really buy us anything. That said, it keeps coming up and I'm tired of repeating myself so I won't block it. |
I honestly just find it weird to have to import |
I didn't want to add that API for |
PR-URL: nodejs#47909 Fixes: nodejs#47897 Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Hopefully not too OT but .. should we have the same for |
What is the problem this feature will solve?
In the Node test runner (https://nodejs.org/api/test.html#test-runner) we have
describe.todo
andit.todo
to designate suites/tests which do not exist yet but we're planning on adding. Thedescribe
>it
syntax is one option of declaring tests, though, there is also justtest
in the API. For those of us who prefertest
overdescribe
, there is no shorthandtest.todo
, only thetest
methodtodo
option: https://nodejs.org/api/test.html#testname-options-fnWhat is the feature you are proposing to solve the problem?
Add
test.todo
similarly to howit.todo
currently exists:What alternatives have you considered?
Not doing it - we do have the
test
todo
option so a shorthand is a QOL/DX improvement not a blocker of anything. I don't see the reason for whyit
should have it andtest
not though. Seems like parity on these would not hurt anything.The text was updated successfully, but these errors were encountered: