Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

spec reporter crash when --required file keep the process alive and timeout reached #49927

Closed
rluvaton opened this issue Sep 28, 2023 · 1 comment · Fixed by #49999
Closed
Labels
confirmed-bug Issues with confirmed bugs. test_runner Issues and PRs related to the test runner subsystem.

Comments

@rluvaton
Copy link
Member

Version

20.7.0

Platform

Darwin Razs-MacBook-Pro.local 23.0.0 Darwin Kernel Version 23.0.0: Fri Sep 15 14:41:43 PDT 2023; root:xnu-10002.1.13~1/RELEASE_ARM64_T6000 arm64

Subsystem

test_runner

What steps will reproduce the bug?

  1. clone https://github.com/rluvaton/spec-reporter-crash-when-timeout-created-in-required-hook
  2. run npm test (this will run node --require ./setup.js ./run-tests.js)

How often does it reproduce? Is there a required condition?

always, you should have something that keeps the process up in the --required file

What is the expected behavior? Why is that the expected behavior?

to not crash

What do you see instead?

crashing:

$ npm test

> spec-reporter-crash-when-timeout-created-in-required-hook@1.0.0 test
> node --require ./setup.js ./run-tests.js

✔ should get a (0.88675ms)
node:internal/test_runner/harness:40
      throw err;
      ^

TypeError [ERR_INVALID_ARG_TYPE]: The "to" argument must be of type string. Received undefined
    at new NodeError (node:internal/errors:405:5)
    at validateString (node:internal/validators:162:11)
    at relative (node:path:1195:5)
    at SpecReporter._flush (node:internal/test_runner/reporter/spec:148:23)
    at SpecReporter.final [as _final] (node:internal/streams/transform:132:10)
    at callFinal (node:internal/streams/writable:707:12)
    at prefinish (node:internal/streams/writable:719:7)
    at finishMaybe (node:internal/streams/writable:729:5)
    at Writable.end (node:internal/streams/writable:641:5)
    at TestsStream.endFn (node:internal/streams/pipeline:430:11)
Emitted 'error' event on Readable instance at:
    at emitErrorNT (node:internal/streams/destroy:151:8)
    at emitErrorCloseNT (node:internal/streams/destroy:116:3)
    at process.processTicksAndRejections (node:internal/process/task_queues:82:21) {
  code: 'ERR_INVALID_ARG_TYPE'
}

Node.js v20.7.0

Additional information

No response

@rluvaton rluvaton added the test_runner Issues and PRs related to the test runner subsystem. label Sep 28, 2023
@rluvaton rluvaton changed the title spec reporter crash when --requireed file keep the process alive and timeout reached spec reporter crash when --required file keep the process alive and timeout reached Sep 28, 2023
@rluvaton rluvaton added the confirmed-bug Issues with confirmed bugs. label Sep 28, 2023
@rluvaton
Copy link
Member Author

related to #49926

cjihrig added a commit to cjihrig/node that referenced this issue Oct 1, 2023
This commit adds the previously missing test location for
FileTest tests.

Fixes: nodejs#49926
Fixes: nodejs#49927
cjihrig added a commit to cjihrig/node that referenced this issue Oct 1, 2023
This commit adds the previously missing test location for
FileTest tests.

Fixes: nodejs#49926
Fixes: nodejs#49927
nodejs-github-bot pushed a commit that referenced this issue Oct 3, 2023
This commit adds the previously missing test location for
FileTest tests.

Fixes: #49926
Fixes: #49927
PR-URL: #49999
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
alexfernandez pushed a commit to alexfernandez/node that referenced this issue Nov 1, 2023
This commit adds the previously missing test location for
FileTest tests.

Fixes: nodejs#49926
Fixes: nodejs#49927
PR-URL: nodejs#49999
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this issue Nov 11, 2023
This commit adds the previously missing test location for
FileTest tests.

Fixes: #49926
Fixes: #49927
PR-URL: #49999
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this issue Nov 27, 2023
This commit adds the previously missing test location for
FileTest tests.

Fixes: #49926
Fixes: #49927
PR-URL: #49999
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
debadree25 pushed a commit to debadree25/node that referenced this issue Apr 15, 2024
This commit adds the previously missing test location for
FileTest tests.

Fixes: nodejs#49926
Fixes: nodejs#49927
PR-URL: nodejs#49999
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher added a commit to sercher/graaljs that referenced this issue Apr 25, 2024
This commit adds the previously missing test location for
FileTest tests.

Fixes: nodejs/node#49926
Fixes: nodejs/node#49927
PR-URL: nodejs/node#49999
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
sercher added a commit to sercher/graaljs that referenced this issue Apr 25, 2024
This commit adds the previously missing test location for
FileTest tests.

Fixes: nodejs/node#49926
Fixes: nodejs/node#49927
PR-URL: nodejs/node#49999
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
confirmed-bug Issues with confirmed bugs. test_runner Issues and PRs related to the test runner subsystem.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant