Skip to content

Missing version info about some members of URL class & URLSearchParams class #55806

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
skyclouds2001 opened this issue Nov 10, 2024 · 5 comments · Fixed by #55818
Closed

Missing version info about some members of URL class & URLSearchParams class #55806

skyclouds2001 opened this issue Nov 10, 2024 · 5 comments · Fixed by #55818
Labels
doc Issues and PRs related to the documentations.

Comments

@skyclouds2001
Copy link
Contributor

skyclouds2001 commented Nov 10, 2024

Affected URL(s)

https://nodejs.org/docs/latest/api/url.html

Description of the problem

some members of URL class & URLSearchParams class didn't list its version info


URL class implement is added in v7.0.0 and v6.13.0, via #7448
URL.prototype.toJSON() implement is added in v7.7.0, via #11236

URLSearchParams class implement is added in v7.0.0 and v6.13.0, as an internal instance, via #7448,
and exported in v7.5.0 via #10801

@skyclouds2001 skyclouds2001 added the doc Issues and PRs related to the documentations. label Nov 10, 2024
@skyclouds2001 skyclouds2001 changed the title Missing version info about some members of URL class Missing version info about some members of URL class & URLSearchParams class Nov 10, 2024
@aduh95
Copy link
Contributor

aduh95 commented Nov 10, 2024

Do you want to submit a PR?

@skyclouds2001

This comment was marked as outdated.

@skyclouds2001
Copy link
Contributor Author

I'd like to make it later. But if someone else is also eager to make, it is fine.

@aduh95
Copy link
Contributor

aduh95 commented Nov 11, 2024

Sure, I didn't want to take credit for your research without your approval.

URL class implement is added in v7.0.0 and v6.13.0, via #7448

IIUC that's already documented:

node/doc/api/url.md

Lines 107 to 112 in 5a775b3

### Class: `URL`
<!-- YAML
added:
- v7.0.0
- v6.13.0

URL.prototype.toJSON() implement is added in v7.7.0, via #11236

Good catch, we can also add that it was backported to 6.13.0. I can open a PR for that. EDIT: that's #55818

URLSearchParams class implement is added in v7.0.0 and v6.13.0, as an internal instance, via #7448,
and exported in v7.5.0 via #10801

It also landed on 6.x thanks to #17365, so I think the documentation is correct

node/doc/api/url.md

Lines 711 to 716 in 5a775b3

### Class: `URLSearchParams`
<!-- YAML
added:
- v7.5.0
- v6.13.0

nodejs-github-bot pushed a commit that referenced this issue Nov 13, 2024
PR-URL: #55818
Fixes: #55806
Refs: #11236
Refs: #17365
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@skyclouds2001
Copy link
Contributor Author

skyclouds2001 commented Nov 13, 2024

More issues find when working with mdn/browser-compat-data#24997 and mdn/browser-compat-data#24998, some are included in #55840 and others I've fired #55841 for it.

aduh95 added a commit that referenced this issue Nov 16, 2024
PR-URL: #55818
Fixes: #55806
Refs: #11236
Refs: #17365
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
tpoisseau pushed a commit to tpoisseau/node that referenced this issue Nov 21, 2024
PR-URL: nodejs#55818
Fixes: nodejs#55806
Refs: nodejs#11236
Refs: nodejs#17365
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Ceres6 pushed a commit to Ceres6/node that referenced this issue Nov 26, 2024
PR-URL: nodejs#55818
Fixes: nodejs#55806
Refs: nodejs#11236
Refs: nodejs#17365
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
ruyadorno pushed a commit that referenced this issue Nov 27, 2024
PR-URL: #55818
Fixes: #55806
Refs: #11236
Refs: #17365
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
ruyadorno pushed a commit that referenced this issue Nov 27, 2024
PR-URL: #55818
Fixes: #55806
Refs: #11236
Refs: #17365
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
ruyadorno pushed a commit that referenced this issue Nov 27, 2024
PR-URL: #55818
Fixes: #55806
Refs: #11236
Refs: #17365
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
marco-ippolito pushed a commit that referenced this issue Jan 22, 2025
PR-URL: #55818
Fixes: #55806
Refs: #11236
Refs: #17365
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
marco-ippolito pushed a commit that referenced this issue Jan 22, 2025
PR-URL: #55818
Fixes: #55806
Refs: #11236
Refs: #17365
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
marco-ippolito pushed a commit that referenced this issue Jan 22, 2025
PR-URL: #55818
Fixes: #55806
Refs: #11236
Refs: #17365
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
marco-ippolito pushed a commit that referenced this issue Jan 24, 2025
PR-URL: #55818
Fixes: #55806
Refs: #11236
Refs: #17365
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants