-
-
Notifications
You must be signed in to change notification settings - Fork 31.7k
Unflag node:sqlite #55854
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Comments
@cjihrig what's missing? |
I think at a minimum there should be some performance work done prior to unflagging because it will likely involve changing the compilation settings. See this comment. It's probably worth asking @tniessen as well, as they have made several changes that would become semver majors if unflagged. (Note, I will be slow to respond for the next day or so.) |
Oh I mean to keep it experimental with a warning on usage, just unflagging it. |
Oh. I'd be happy to see the flag go. +1. |
This commit allows the node:sqlite module to be used without starting Node with a CLI flag. The module is still experimental. Fixes: nodejs#55854
This commit allows the node:sqlite module to be used without starting Node with a CLI flag. The module is still experimental. Fixes: nodejs#55854
This commit allows the node:sqlite module to be used without starting Node with a CLI flag. The module is still experimental. Fixes: nodejs#55854 PR-URL: nodejs#55890 Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This commit allows the node:sqlite module to be used without starting Node with a CLI flag. The module is still experimental. Fixes: nodejs#55854 PR-URL: nodejs#55890 Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This commit allows the node:sqlite module to be used without starting Node with a CLI flag. The module is still experimental. Fixes: #55854 PR-URL: #55890 Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This commit allows the node:sqlite module to be used without starting Node with a CLI flag. The module is still experimental. Fixes: #55854 PR-URL: #55890 Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This commit allows the node:sqlite module to be used without starting Node with a CLI flag. The module is still experimental. Fixes: #55854 PR-URL: #55890 Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
I think we should plan to unflag
node:sqlite
, as it has been flagged for a while and we plan to use it in Undici to provide an HTTP cache store: nodejs/undici#3657.The text was updated successfully, but these errors were encountered: