Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Build fails with gcc v15 - uint64_t undefined #56731

Closed
tjuhaszrh opened this issue Jan 23, 2025 · 1 comment · Fixed by #56740
Closed

Build fails with gcc v15 - uint64_t undefined #56731

tjuhaszrh opened this issue Jan 23, 2025 · 1 comment · Fixed by #56740

Comments

@tjuhaszrh
Copy link
Contributor

tjuhaszrh commented Jan 23, 2025 •
edited by aduh95
Loading

Version

18, 20

Platform

Linux vm-10-0-186-232.hosted.upshift.rdu2.redhat.com 6.13.0-0.rc7.20250114gitc45323b7560e.56.fc42.x86_64

Subsystem

No response

What steps will reproduce the bug?

Following the build guide with gcc 15.
Running:

./configure
make -j4

How often does it reproduce? Is there a required condition?

Every build with gcc 15 fails

What is the expected behavior? Why is that the expected behavior?

Successful build

What do you see instead?

In file included from ../../src/inspector/worker_inspector.cc:1:

../../src/inspector/worker_inspector.h:56:33: error: expected ‘)’ before ‘id’
   56 |   ParentInspectorHandle(uint64_t id,
      |                        ~        ^~~
      |                                 )

../../src/inspector/worker_inspector.h:63:7: **error: ‘uint64_t’ has not been declared**
   63 |       uint64_t thread_id, const std::string& url, const std::string& name) {
      |       ^~~~~~~~

../../src/inspector/worker_inspector.h:12:1: note: ‘uint64_t’ is defined in header ‘<cstdint>’; this is probably fixable by adding ‘#include <cstdint>’
   11 | #include <unordered_set>
  +++ |+#include <cstdint>

Additional information

Seems to be related to changes to libstdc++, which have removed transitive includes of <cstdint>.

Adding the include into worker_inspector.h allows for successful built
@aduh95
Copy link
Contributor

aduh95 commented Jan 23, 2025

Would you like to send a PR?

@tjuhaszrh tjuhaszrh mentioned this issue Jan 23, 2025
Closed
tjuhaszrh added a commit to tjuhaszrh/node that referenced this issue Jan 24, 2025
@tjuhaszrh
src: Adding #include <cstdint> to worker_inspector. h for gcc v15
a6eedd7 
Added cstdint to worker_inspector as on more recent version of gcc
the build was failing due to changes to libstdc++ and the removal
of transitive includes

Fixes: nodejs#56731
@tjuhaszrh tjuhaszrh mentioned this issue Jan 24, 2025
Merged
aduh95 pushed a commit that referenced this issue Jan 25, 2025
@tjuhaszrh
src: fix build with GCC 15
bade7a1 
Added cstdint to worker_inspector as on more recent version of gcc
the build was failing due to changes to libstdc++ and the removal
of transitive includes.

PR-URL: #56740
Fixes: #56731
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this issue Jan 27, 2025
@tjuhaszrh @aduh95
src: fix build with GCC 15
d84b3a9 
Added cstdint to worker_inspector as on more recent version of gcc
the build was failing due to changes to libstdc++ and the removal
of transitive includes.

PR-URL: #56740
Fixes: #56731
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this issue Jan 30, 2025
@tjuhaszrh @aduh95
src: fix build with GCC 15
83c56da 
Added cstdint to worker_inspector as on more recent version of gcc
the build was failing due to changes to libstdc++ and the removal
of transitive includes.

PR-URL: #56740
Fixes: #56731
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
hvanness pushed a commit to hvanness/node that referenced this issue Jan 30, 2025
@tjuhaszrh @hvanness
src: fix build with GCC 15
0b13d32 
Added cstdint to worker_inspector as on more recent version of gcc
the build was failing due to changes to libstdc++ and the removal
of transitive includes.

PR-URL: nodejs#56740
Fixes: nodejs#56731
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this issue Jan 31, 2025
@tjuhaszrh @aduh95
src: fix build with GCC 15
fbfa35e 
Added cstdint to worker_inspector as on more recent version of gcc
the build was failing due to changes to libstdc++ and the removal
of transitive includes.

PR-URL: #56740
Fixes: #56731
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this issue Feb 4, 2025
@tjuhaszrh @aduh95
src: fix build with GCC 15
a3054b8 
Added cstdint to worker_inspector as on more recent version of gcc
the build was failing due to changes to libstdc++ and the removal
of transitive includes.

PR-URL: #56740
Fixes: #56731
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 pushed a commit that referenced this issue Feb 6, 2025
@tjuhaszrh @aduh95
src: fix build with GCC 15
7bae51e 
Added cstdint to worker_inspector as on more recent version of gcc
the build was failing due to changes to libstdc++ and the removal
of transitive includes.

PR-URL: #56740
Fixes: #56731
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
marco-ippolito pushed a commit that referenced this issue Mar 6, 2025
@tjuhaszrh @marco-ippolito
src: fix build with GCC 15
d4d6573 
Added cstdint to worker_inspector as on more recent version of gcc
the build was failing due to changes to libstdc++ and the removal
of transitive includes.

PR-URL: #56740
Fixes: #56731
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
marco-ippolito pushed a commit that referenced this issue Mar 6, 2025
@tjuhaszrh @marco-ippolito
src: fix build with GCC 15
5efbd44 
Added cstdint to worker_inspector as on more recent version of gcc
the build was failing due to changes to libstdc++ and the removal
of transitive includes.

PR-URL: #56740
Fixes: #56731
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
marco-ippolito pushed a commit that referenced this issue Mar 6, 2025
@tjuhaszrh @marco-ippolito
src: fix build with GCC 15
e3b69e5 
Added cstdint to worker_inspector as on more recent version of gcc
the build was failing due to changes to libstdc++ and the removal
of transitive includes.

PR-URL: #56740
Fixes: #56731
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

src: adding #include <cstdint> to worker_inspector. h for gcc v15 tjuhaszrh/node
2 participants
@aduh95 @tjuhaszrh