Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

--inspect connection dies before profiler captures trace #7088

Closed
nojvek opened this issue Jun 1, 2016 · 4 comments
Closed

--inspect connection dies before profiler captures trace #7088

nojvek opened this issue Jun 1, 2016 · 4 comments
Labels
inspector Issues and PRs related to the V8 inspector protocol

Comments

@nojvek
Copy link

nojvek commented Jun 1, 2016

  • Version: v7.0.0-pre
  • Platform:
  • Subsystem:

Its a common scenario to profile the execution of a node script. e.g the tsc compiler. The use case is to get a flamechart of the execution of a script. When the script finishes the debugging connection is closed so the flamechart cannot be analyzed.

Expected:
when capturing cpu profiles in inspect mode, the debugging connection should remain open until the profile is fully captured and ready for post analysis. Alternatively there should be a way to tell inspect not to kill the connection once the script finishes.

/cc @ofrobots @pavelfeldman

@mscdex mscdex added the debugger label Jun 1, 2016
@ofrobots
Copy link
Contributor

ofrobots commented Jun 1, 2016

/cc @eugeneo

@mscdex mscdex added inspector Issues and PRs related to the V8 inspector protocol and removed debugger labels Jun 3, 2016
@eugeneo
Copy link
Contributor

eugeneo commented Jun 8, 2016

I am unable to reproduce the issue. I get a prompt "Waiting for the debugger to disconnect..." whenever I run script to a completion with an inspector connected.

Note that you may be hitting a different issue that we will upload a fix shortly - sometimes V8 inspector does not attach to V8 running long JS script. Have you tried running your application with "--debug-brk" command line switch? It enables inspector connection before running the script.

@pavelfeldman
Copy link
Contributor

@eugeneo i can easily repro it. I start with --debug-brk and start profiling while on a breakpoint. App finishes, connections terminates. This is a regression.

@nojvek
Copy link
Author

nojvek commented Jun 13, 2016

I'll try it out to confirm its fixed.

On Monday, June 13, 2016, Ali Ijaz Sheikh notifications@github.com wrote:

Closed #7088 #7088 via 6626919
6626919
.


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#7088 (comment), or mute the
thread
https://github.com/notifications/unsubscribe/AA-JVOEW4YUT6oVCjqhv2GKcJXFRScj7ks5qLX-jgaJpZM4IrGry
.

Fishrock123 pushed a commit that referenced this issue Jul 5, 2016
Fixes: #7088
PR-URL: #7252
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>

 Conflicts:
	src/node.cc
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants