Skip to content

Suggestion: http doc should mention special handling for HEAD and 304 #8057

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
hnry opened this issue Aug 10, 2016 · 1 comment
Closed

Suggestion: http doc should mention special handling for HEAD and 304 #8057

hnry opened this issue Aug 10, 2016 · 1 comment
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. http Issues or PRs related to the http subsystem.

Comments

@hnry
Copy link
Contributor

hnry commented Aug 10, 2016 •
edited
Loading

  • Version: 4.4.7 , 6.3.1
  • Platform: OS X
  • Subsystem: http

I think it would be a good idea to mention in the official docs that the http module will ignore any response body if the incoming request is a HEAD request, and the same behavior for 304 responses.

And any other special handling the http module does.

Reasoning is, I had no way of knowing if this was official behavior since it was undocumented, and when it first existed / introduced so I had to test it myself to see across a few node versions. So it would've saved me some time and others time in the future.

If it exists already, my apologies, I tried looking through the http doc but could not find a mention.
@mscdex mscdex added http Issues or PRs related to the http subsystem. doc Issues and PRs related to the documentations. labels Aug 10, 2016
@jasnell jasnell added the good first issue Issues that are suitable for first-time contributors. label Sep 9, 2016
@tanujasawant
Copy link
Contributor

I can take this up if someone can help me get started. Would you kindly?

This was referenced Oct 8, 2016
Closed
Closed
minervapanda added a commit to minervapanda/node that referenced this issue Oct 9, 2016
@minervapanda
doc: response body in http module
f2bcdea 
Fixes: nodejs#8057
@minervapanda minervapanda mentioned this issue Nov 2, 2016
Closed
2 tasks
@krydos krydos mentioned this issue Apr 10, 2017
Closed
2 tasks
krydos added a commit to krydos/node that referenced this issue Apr 12, 2017
@krydos
doc: response.write ignores body in some cases
734a8d9 
Fixes: nodejs#8057
evanlucas pushed a commit that referenced this issue Apr 25, 2017
@krydos @evanlucas
doc: response.write ignores body in some cases
3e32361 
PR-URL: #12314
Fixes: #8057
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
evanlucas pushed a commit that referenced this issue May 1, 2017
@krydos @evanlucas
doc: response.write ignores body in some cases
5128c2f 
PR-URL: #12314
Fixes: #8057
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
evanlucas pushed a commit that referenced this issue May 2, 2017
@krydos @evanlucas
doc: response.write ignores body in some cases
e2d66ab 
PR-URL: #12314
Fixes: #8057
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this issue May 15, 2017
@krydos @MylesBorins
doc: response.write ignores body in some cases
9d2a5fb 
PR-URL: #12314
Fixes: #8057
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this issue May 18, 2017
@krydos @MylesBorins
doc: response.write ignores body in some cases
3c1bd05 
PR-URL: #12314
Fixes: #8057
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
andrew749 pushed a commit to michielbaird/node that referenced this issue Jul 19, 2017
@krydos @andrew749
doc: response.write ignores body in some cases
1ec0028 
PR-URL: nodejs/node#12314
Fixes: nodejs/node#8057
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. good first issue Issues that are suitable for first-time contributors. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

doc: response.write ignores body in some cases krydos/node
4 participants
@hnry @mscdex @jasnell @tanujasawant