Skip to content

v8_inspector: HTTP /json/version returns array instead of object #9760

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
auchenberg opened this issue Nov 23, 2016 · 1 comment
Closed

v8_inspector: HTTP /json/version returns array instead of object #9760

auchenberg opened this issue Nov 23, 2016 · 1 comment
Labels
inspector Issues and PRs related to the V8 inspector protocol

Comments

@auchenberg
Copy link

Version: v7.2.0
Platform: Darwin MacBook-234.local 16.0.0 Darwin Kernel Version 16.0.0: Mon Aug 29 17:56:20 PDT 2016; root:xnu-3789.1.32~3/RELEASE_X86_64 x86_64
Subsystem: v8_inspector

Steps:

  1. Start node --inspect
  2. Go to http://localhost:9229/json/version

Actual response:
The HTTP /json/version returns the version object wrapped in array

[ {
  "Browser": "node.js/v7.2.0",
  "Protocol-Version": "1.1"
} ]

Expected response:
The HTTP /json/version should return object in alignment with Chrome and other browsers.

{
  "Browser": "node.js/v7.2.0",
  "Protocol-Version": "1.1"
}
@bnoordhuis bnoordhuis mentioned this issue Nov 23, 2016
Merged
@bnoordhuis bnoordhuis added the inspector Issues and PRs related to the V8 inspector protocol label Nov 23, 2016
@bnoordhuis
Copy link
Member

#9762

bnoordhuis added a commit to bnoordhuis/io.js that referenced this issue Nov 25, 2016
@bnoordhuis
inspector: /json/version returns object, not array
e27f14f 
Make /json/version return an object instead of an object wrapped in an
array.

Fixes: nodejs#9760
PR-URL: nodejs#9762
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
addaleax pushed a commit that referenced this issue Dec 5, 2016
@bnoordhuis @addaleax
inspector: /json/version returns object, not array
80a3934 
Make /json/version return an object instead of an object wrapped in an
array.

Fixes: #9760
PR-URL: #9762
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins pushed a commit that referenced this issue Dec 20, 2016
@bnoordhuis @MylesBorins
inspector: /json/version returns object, not array
a3ba4ff 
Make /json/version return an object instead of an object wrapped in an
array.

Fixes: #9760
PR-URL: #9762
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins pushed a commit that referenced this issue Dec 21, 2016
@bnoordhuis @MylesBorins
inspector: /json/version returns object, not array
de2749b 
Make /json/version return an object instead of an object wrapped in an
array.

Fixes: #9760
PR-URL: #9762
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@auchenberg @bnoordhuis