Skip to content

[buffer] fill() for utf16le is broken #9836

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
trevnorris opened this issue Nov 29, 2016 · 1 comment
Closed

[buffer] fill() for utf16le is broken #9836

trevnorris opened this issue Nov 29, 2016 · 1 comment
Labels
buffer Issues and PRs related to the buffer subsystem.

Comments

@trevnorris
Copy link
Contributor

  • Version: v6.9.1
  • Platform: Linux
  • Subsystem: buffer

Example of brokenness:

Buffer.allocUnsafeSlow(16).fill('a', 'utf16le').toString('utf16le')
// expect: 'aaaaaaaa'
// get:    '慡慡慡慡慡慡慡慡'

Seems to be treating the character as latin1.
@trevnorris trevnorris added the buffer Issues and PRs related to the buffer subsystem. label Nov 29, 2016
@addaleax addaleax mentioned this issue Nov 29, 2016
Closed
3 tasks
addaleax added a commit to addaleax/node that referenced this issue Nov 29, 2016
@addaleax
buffer: fix single-character string filling
641cfa2 
Fix the fast path for `buffer.fill()` with a single-character string.

The fast path only works for strings that are equivalent to a
single-byte buffer, but that condition was not checked properly
for the `utf8` or `utf16le` encodings and is always true for the
`latin1` encoding.

This change fixes these problems.

Fixes: nodejs#9836
addaleax added a commit to addaleax/node that referenced this issue Dec 12, 2016
@addaleax
buffer: fix single-character string filling
b0a80b7 
Fix the fast path for `buffer.fill()` with a single-character string.

The fast path only works for strings that are equivalent to a
single-byte buffer, but that condition was not checked properly
for the `utf8` or `utf16le` encodings and is always true for the
`latin1` encoding.

This change fixes these problems.

Fixes: nodejs#9836
@trevnorris
Copy link
Contributor Author

Thanks @addaleax!

Fishrock123 pushed a commit that referenced this issue Dec 13, 2016
@addaleax @Fishrock123
buffer: fix single-character string filling
b99a372 
Fix the fast path for `buffer.fill()` with a single-character string.

The fast path only works for strings that are equivalent to a
single-byte buffer, but that condition was not checked properly
for the `utf8` or `utf16le` encodings and is always true for the
`latin1` encoding.

This change fixes these problems.

Fixes: #9836
PR-URL: #9837
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
MylesBorins pushed a commit that referenced this issue Jan 23, 2017
@addaleax @MylesBorins
buffer: fix single-character string filling
e76a7e0 
Fix the fast path for `buffer.fill()` with a single-character string.

The fast path only works for strings that are equivalent to a
single-byte buffer, but that condition was not checked properly
for the `utf8` or `utf16le` encodings and is always true for the
`latin1` encoding.

This change fixes these problems.

Fixes: #9836
PR-URL: #9837
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
MylesBorins pushed a commit that referenced this issue Jan 24, 2017
@addaleax @MylesBorins
buffer: fix single-character string filling
9eaa721 
Fix the fast path for `buffer.fill()` with a single-character string.

The fast path only works for strings that are equivalent to a
single-byte buffer, but that condition was not checked properly
for the `utf8` or `utf16le` encodings and is always true for the
`latin1` encoding.

This change fixes these problems.

Fixes: #9836
PR-URL: #9837
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
MylesBorins pushed a commit that referenced this issue Jan 31, 2017
@addaleax @MylesBorins
buffer: fix single-character string filling
40c7ec6 
Fix the fast path for `buffer.fill()` with a single-character string.

The fast path only works for strings that are equivalent to a
single-byte buffer, but that condition was not checked properly
for the `utf8` or `utf16le` encodings and is always true for the
`latin1` encoding.

This change fixes these problems.

Fixes: #9836
PR-URL: #9837
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
buffer Issues and PRs related to the buffer subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

buffer: fix single-character string filling addaleax/node
1 participant
@trevnorris