Skip to content

test: refactor test-dgram-exclusive-implicit-bind.js #10066

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

test: refactor test-dgram-exclusive-implicit-bind.js #10066

wants to merge 1 commit into from

Conversation

cesarhq
Copy link
Contributor

@cesarhq cesarhq commented Dec 1, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
Affected core subsystem(s)
  • test
Description of change
    * assert.equal() -> assert.strictEqual()

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
cjihrig
cjihrig approved these changes Dec 1, 2016
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM. The commit message is too long though.

@julianduque julianduque added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. dgram Issues and PRs related to the dgram subsystem / UDP. labels Dec 1, 2016
@cesarhq
test: refactor test-dgram-exclusive-implicit-bind
7493746 
        * assert.equal() -> assert.strictEqual()
@cesarhq cesarhq force-pushed the cleanup-test-dgram-exclusive-implicit-bind branch from 032165d to 7493746 Compare December 1, 2016 20:11
@addaleax
Copy link
Member

addaleax commented Dec 2, 2016

CI: https://ci.nodejs.org/job/node-test-commit/6324/

@addaleax
Copy link
Member

addaleax commented Dec 4, 2016

Landed in 4601d5a, thanks for the contribution!

@addaleax addaleax closed this Dec 4, 2016
addaleax pushed a commit that referenced this pull request Dec 4, 2016
@cesarhq @addaleax
test: refactor test-dgram-exclusive-implicit-bind
4601d5a 
 * assert.equal() -> assert.strictEqual()

PR-URL: #10066
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
addaleax pushed a commit that referenced this pull request Dec 5, 2016
@cesarhq @addaleax
test: refactor test-dgram-exclusive-implicit-bind
a34e195 
 * assert.equal() -> assert.strictEqual()

PR-URL: #10066
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
@Fishrock123 Fishrock123 mentioned this pull request Dec 5, 2016
Merged
2 tasks
addaleax pushed a commit to addaleax/node that referenced this pull request Dec 8, 2016
@cesarhq @addaleax
test: refactor test-dgram-exclusive-implicit-bind
f10c321 
 * assert.equal() -> assert.strictEqual()

PR-URL: nodejs#10066
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
jmdarling pushed a commit to jmdarling/node that referenced this pull request Dec 8, 2016
@cesarhq
test: refactor test-dgram-exclusive-implicit-bind
9180d06 
 * assert.equal() -> assert.strictEqual()

PR-URL: nodejs#10066
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 20, 2016
@cesarhq @MylesBorins
test: refactor test-dgram-exclusive-implicit-bind
80a7527 
 * assert.equal() -> assert.strictEqual()

PR-URL: #10066
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@cesarhq @MylesBorins
test: refactor test-dgram-exclusive-implicit-bind
d0f8b0d 
 * assert.equal() -> assert.strictEqual()

PR-URL: #10066
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 21, 2016
@cesarhq @MylesBorins
test: refactor test-dgram-exclusive-implicit-bind
781d1d9 
 * assert.equal() -> assert.strictEqual()

PR-URL: #10066
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
This was referenced Dec 21, 2016
Merged
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@santigimeno santigimeno santigimeno approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. dgram Issues and PRs related to the dgram subsystem / UDP. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cesarhq @addaleax @santigimeno @cjihrig @MylesBorins @julianduque @nodejs-github-bot