s390: enable march=z196 #11730
Closed
s390: enable march=z196 #11730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
build
|
@nodejs/platform-s390 |
sam-github
approved these changes
Mar 7, 2017
gibfahn
approved these changes
Mar 7, 2017
|
LGTM. http://www-03.ibm.com/systems/z/os/linux/resources/testedplatforms.html shows that matches the minimum hardware requirements for the distros with right level of GCC/Glibc support (SLES 12, RHEL 7, Ubuntu 16.04 or newer). |
jbajwa
approved these changes
Mar 7, 2017
richardlau
approved these changes
Mar 7, 2017
|
Hard to believe this broke OS X, try again: |
|
LGTM |
|
@sam-github It doesn't seem to fail by looking at the details of ARM build. |
|
ARM builds always fail, so ci result is a pass. |
|
Rerun of CI was green (arm failure on Github is a reporting issue, you need to click on the CI link). EDIT: what Sam said |
|
any updates on this? |
|
Requires 2 mid-week days to give people time to comment before it can be merged. |
jasnell
approved these changes
Mar 8, 2017
cjihrig
approved these changes
Mar 9, 2017
|
Landing since its now past the wait time. |
|
Landed as b806e18 |
mhdawson
pushed a commit
that referenced
this pull request
Mar 10, 2017
PR-URL: #11730 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Mar 13, 2017
PR-URL: nodejs#11730 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
jungx098
pushed a commit
to jungx098/node
that referenced
this pull request
Mar 21, 2017
PR-URL: nodejs#11730 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
should this be backported to v6.x? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable -march=z196 for s390, because it's the lowest platform we intend to support for zlinux platforms.