Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

test: add more test cases of server.listen option #11778

Closed
wants to merge 5 commits into from
Closed

test: add more test cases of server.listen option #11778

wants to merge 5 commits into from

Conversation

joyeecheung
Copy link
Member

@joyeecheung joyeecheung commented Mar 10, 2017 •
edited
Loading

  • Test different handle and fd
  • Test listen without callback

TODO: do the same thing to socket.connect, net.connect to prevent #11761 from happening again (in the test file added in its fix, probably).

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test, net

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Mar 10, 2017
@joyeecheung joyeecheung force-pushed the listen-options-test branch from 3eca24b to cc696a7 Compare March 10, 2017 01:56
@joyeecheung
Copy link
Member Author

joyeecheung commented Mar 10, 2017 •
edited
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/6786/
Got some errors on windows-fanned, dump the error number in message and try again..https://ci.nodejs.org/job/node-test-pull-request/6787/

@mscdex mscdex added the net Issues and PRs related to the net subsystem. label Mar 10, 2017
@joyeecheung joyeecheung force-pushed the listen-options-test branch from a0f61e3 to e5458f9 Compare March 10, 2017 03:28
@joyeecheung joyeecheung force-pushed the listen-options-test branch from 4030d1b to 7b65fa6 Compare March 10, 2017 04:48
@joyeecheung joyeecheung changed the title test: add more test cases of server.listen option [WIP] test: add more test cases of server.listen option Mar 10, 2017
@joyeecheung
Copy link
Member Author

This doesn't unlink the pipes it creates properly at the moment(so rerun it without refreshing tmpdir would get a EADDRINUSE)..marking as WIP

@joyeecheung
Copy link
Member Author

joyeecheung commented Mar 10, 2017 •
edited
Loading

Got rid of errors on windows (forgot there is no support for server.listen({fd: n}) on Windows per the docs, hence neither server.listen(pipeHandle))..

New CI: https://ci.nodejs.org/job/node-test-pull-request/6792/

CentOS failures should be unrelated(dns failures, passed in a previous https://ci.nodejs.org/job/node-test-commit-linux/8380/)

@jasnell PTAL, thanks.

@joyeecheung joyeecheung changed the title [WIP] test: add more test cases of server.listen option test: add more test cases of server.listen option Mar 10, 2017
@joyeecheung
Copy link
Member Author

Last CI: https://ci.nodejs.org/job/node-test-pull-request/6868/

@joyeecheung
Copy link
Member Author

Landed in 474e9d6, thanks!

joyeecheung added a commit that referenced this pull request Mar 16, 2017
@joyeecheung
test: add more test cases of server.listen option
474e9d6 
* Test listening with different handle and fd
* Test listening without callback

PR-URL: #11778
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
jungx098 pushed a commit to jungx098/node that referenced this pull request Mar 21, 2017
@joyeecheung @jungx098
test: add more test cases of server.listen option
12181ab 
* Test listening with different handle and fd
* Test listening without callback

PR-URL: nodejs#11778
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
@italoacasas
Copy link
Contributor

This PR need backport to v7

@joyeecheung
Copy link
Member Author

Depends on #11693, opening a backport PR...

@joyeecheung joyeecheung mentioned this pull request Apr 11, 2017
Closed
3 tasks
joyeecheung added a commit to joyeecheung/node that referenced this pull request Apr 11, 2017
@joyeecheung
test: add more test cases of server.listen option
58a342b 
* Test listening with different handle and fd
* Test listening without callback

PR-URL: nodejs#11778
@joyeecheung joyeecheung self-assigned this Oct 17, 2017
@joyeecheung joyeecheung removed their assignment Nov 1, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@sam-github sam-github sam-github approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
net Issues and PRs related to the net subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@joyeecheung @italoacasas @sam-github @jasnell @mscdex @gibfahn @nodejs-github-bot