Skip to content

url: remove javascript URL special case #12331

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

url: remove javascript URL special case #12331

wants to merge 1 commit into from

Conversation

watilde
Copy link
Contributor

@watilde watilde commented Apr 11, 2017

Fixes: #11485

Checklist
Affected core subsystem(s)

url

@nodejs-github-bot nodejs-github-bot added dont-land-on-v4.x whatwg-url Issues and PRs related to the WHATWG URL implementation. labels Apr 11, 2017
@watilde
Copy link
Contributor Author

watilde commented Apr 11, 2017

ci: https://ci.nodejs.org/job/node-test-pull-request/7328/

@watilde
Copy link
Contributor Author

watilde commented Apr 11, 2017

The windows-fanned failure looks unrelated.

@watilde
Copy link
Contributor Author

watilde commented Apr 12, 2017

Landed in eb0492d. Thanks!

@watilde watilde closed this Apr 12, 2017
@watilde watilde deleted the feature/hash-javascript branch April 12, 2017 18:54
watilde added a commit that referenced this pull request Apr 12, 2017
@watilde
url: remove javascript URL special case
eb0492d 
Fixes: #11485
PR-URL: #12331
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@TimothyGu TimothyGu mentioned this pull request Apr 19, 2017
Merged
4 tasks
@jasnell jasnell mentioned this pull request May 11, 2017
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@TimothyGu TimothyGu TimothyGu approved these changes

@targos targos targos approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
whatwg-url Issues and PRs related to the WHATWG URL implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@watilde @jasnell @TimothyGu @targos @cjihrig @nodejs-github-bot