Skip to content

n-api: fix -Wmismatched-tags compiler warning #12333

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2017
Merged

n-api: fix -Wmismatched-tags compiler warning #12333

merged 1 commit into from
Apr 11, 2017

Conversation

bnoordhuis
Copy link
Member

napi_env__ was declared as a struct in one place and a class in
another.

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Apr 11, 2017
addaleax
addaleax approved these changes Apr 11, 2017
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and probably shouldn’t need 48 hours to land.

@addaleax addaleax added the node-api Issues and PRs related to the Node-API. label Apr 11, 2017
@bnoordhuis
Copy link
Member Author

CI: https://ci.nodejs.org/job/node-test-pull-request/7331/

cjihrig
cjihrig approved these changes Apr 11, 2017
View reviewed changes
Copy link
Contributor

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To save you from checking, the CI is green.

@bnoordhuis
n-api: fix -Wmismatched-tags compiler warning
affe0f2 
`napi_env__` was declared as a struct in one place and a class in
another.

PR-URL: nodejs#12333
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@bnoordhuis bnoordhuis force-pushed the fix-napi-compiler-warning branch from 57f7df3 to affe0f2 Compare April 11, 2017 14:00
@bnoordhuis bnoordhuis closed this Apr 11, 2017
@bnoordhuis bnoordhuis deleted the fix-napi-compiler-warning branch April 11, 2017 14:01
@bnoordhuis bnoordhuis merged commit affe0f2 into nodejs:master Apr 11, 2017
@jasnell jasnell mentioned this pull request May 11, 2017
Closed
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 10, 2018
@bnoordhuis
n-api: fix -Wmismatched-tags compiler warning
e6055bb 
`napi_env__` was declared as a struct in one place and a class in
another.

PR-URL: nodejs#12333
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
@bnoordhuis @MylesBorins
n-api: fix -Wmismatched-tags compiler warning
eb51d42 
`napi_env__` was declared as a struct in one place and a class in
another.

Backport-PR-URL: #19447
PR-URL: #12333
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 16, 2018
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@danbev danbev danbev approved these changes

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bnoordhuis @danbev @jasnell @addaleax @cjihrig @nodejs-github-bot