deps: cherry-pick bfae9db from upstream v8 #12722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
v8 engine
targos
approved these changes
Apr 28, 2017
mscdex
added
the
post-mortem
jasnell
approved these changes
Apr 28, 2017
Original commit message:
Update postmortem metadata generator.
Add PropertyDetails::AttributesField +
PropertyDetails::LocationField.
Review-Url: https://codereview.chromium.org/2842843004
Cr-Commit-Position: refs/heads/master@{nodejs#44889}
PR-URL: nodejs#12722
Refs: nodejs/llnode#81
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
bnoordhuis
force-pushed
the
cherry-pick-bfae9db
branch
from
1948f3c to
6ed791c
Compare
|
Landed in 6ed791c. For posterity, CI URL is https://ci.nodejs.org/job/node-test-pull-request/7770/ |
|
I'm assuming this shouldn't land on v7.x? |
|
I think it could but llnode won't use it. There should be no negative consequences to back-porting. |
|
Thanks for the confirmation Ben! |
anchnk
pushed a commit
to anchnk/node
that referenced
this pull request
May 6, 2017
Original commit message:
Update postmortem metadata generator.
Add PropertyDetails::AttributesField +
PropertyDetails::LocationField.
Review-Url: https://codereview.chromium.org/2842843004
Cr-Commit-Position: refs/heads/master@{nodejs#44889}
PR-URL: nodejs#12722
Refs: nodejs/llnode#81
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos
pushed a commit
to targos/node
that referenced
this pull request
May 6, 2017
Original commit message:
Update postmortem metadata generator.
Add PropertyDetails::AttributesField +
PropertyDetails::LocationField.
Review-Url: https://codereview.chromium.org/2842843004
Cr-Commit-Position: refs/heads/master@{nodejs#44889}
PR-URL: nodejs#12722
Refs: nodejs/llnode#81
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos
pushed a commit
that referenced
this pull request
May 6, 2017
Original commit message:
Update postmortem metadata generator.
Add PropertyDetails::AttributesField +
PropertyDetails::LocationField.
Review-Url: https://codereview.chromium.org/2842843004
Cr-Commit-Position: refs/heads/master@{#44889}
PR-URL: #12722
Refs: nodejs/llnode#81
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos
pushed a commit
to targos/node
that referenced
this pull request
Jun 6, 2017
Original commit message:
Update postmortem metadata generator.
Add PropertyDetails::AttributesField +
PropertyDetails::LocationField.
Review-Url: https://codereview.chromium.org/2842843004
Cr-Commit-Position: refs/heads/master@{nodejs#44889}
PR-URL: nodejs#12722
Refs: nodejs/llnode#81
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos
pushed a commit
to targos/node
that referenced
this pull request
Jun 7, 2017
Original commit message:
Update postmortem metadata generator.
Add PropertyDetails::AttributesField +
PropertyDetails::LocationField.
Review-Url: https://codereview.chromium.org/2842843004
Cr-Commit-Position: refs/heads/master@{nodejs#44889}
PR-URL: nodejs#12722
Refs: nodejs/llnode#81
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
3 tasks
addaleax
pushed a commit
that referenced
this pull request
Jun 17, 2017
Original commit message:
Update postmortem metadata generator.
Add PropertyDetails::AttributesField +
PropertyDetails::LocationField.
Review-Url: https://codereview.chromium.org/2842843004
Cr-Commit-Position: refs/heads/master@{#44889}
PR-URL: #12722
Refs: nodejs/llnode#81
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
|
@bnoordhuis should this land on v6.x? |
|
No. I've added labels. |
addaleax
pushed a commit
that referenced
this pull request
Jun 21, 2017
Original commit message:
Update postmortem metadata generator.
Add PropertyDetails::AttributesField +
PropertyDetails::LocationField.
Review-Url: https://codereview.chromium.org/2842843004
Cr-Commit-Position: refs/heads/master@{#44889}
PR-URL: #12722
Refs: nodejs/llnode#81
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
addaleax
pushed a commit
that referenced
this pull request
Jun 24, 2017
Original commit message:
Update postmortem metadata generator.
Add PropertyDetails::AttributesField +
PropertyDetails::LocationField.
Review-Url: https://codereview.chromium.org/2842843004
Cr-Commit-Position: refs/heads/master@{#44889}
PR-URL: #12722
Refs: nodejs/llnode#81
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
rvagg
pushed a commit
that referenced
this pull request
Jun 29, 2017
Original commit message:
Update postmortem metadata generator.
Add PropertyDetails::AttributesField +
PropertyDetails::LocationField.
Review-Url: https://codereview.chromium.org/2842843004
Cr-Commit-Position: refs/heads/master@{#44889}
PR-URL: #12722
Refs: nodejs/llnode#81
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
addaleax
pushed a commit
that referenced
this pull request
Jul 11, 2017
Original commit message:
Update postmortem metadata generator.
Add PropertyDetails::AttributesField +
PropertyDetails::LocationField.
Review-Url: https://codereview.chromium.org/2842843004
Cr-Commit-Position: refs/heads/master@{#44889}
PR-URL: #12722
Refs: nodejs/llnode#81
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
addaleax
pushed a commit
that referenced
this pull request
Jul 18, 2017
Original commit message:
Update postmortem metadata generator.
Add PropertyDetails::AttributesField +
PropertyDetails::LocationField.
Review-Url: https://codereview.chromium.org/2842843004
Cr-Commit-Position: refs/heads/master@{#44889}
PR-URL: #12722
Refs: nodejs/llnode#81
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos
pushed a commit
to targos/node
that referenced
this pull request
Jul 21, 2017
Original commit message:
Update postmortem metadata generator.
Add PropertyDetails::AttributesField +
PropertyDetails::LocationField.
Review-Url: https://codereview.chromium.org/2842843004
Cr-Commit-Position: refs/heads/master@{nodejs#44889}
PR-URL: nodejs#12722
Refs: nodejs/llnode#81
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
addaleax
pushed a commit
that referenced
this pull request
Jul 24, 2017
Original commit message:
Update postmortem metadata generator.
Add PropertyDetails::AttributesField +
PropertyDetails::LocationField.
Review-Url: https://codereview.chromium.org/2842843004
Cr-Commit-Position: refs/heads/master@{#44889}
PR-URL: #12722
Refs: nodejs/llnode#81
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Closed
This was referenced May 14, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original commit message:
Refs: nodejs/llnode#81