Skip to content

doc: fix commit guideline url #12862

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

doc: fix commit guideline url #12862

wants to merge 1 commit into from

Conversation

watson
Copy link
Member

@watson watson commented May 5, 2017

Checklist
Affected core subsystem(s)
  • doc

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label May 5, 2017
@vsemozhetbyt
Copy link
Contributor

Can we land this without the common delay?

@Trott
Copy link
Member

Trott commented May 5, 2017

Can we land this without the common delay?

Yes, please!

I think I'm the one that broke it, so sorry about that, and thanks for fixing it.

Trott
Trott approved these changes May 5, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Trott
Copy link
Member

Trott commented May 5, 2017

Landed in 4703824

@Trott Trott closed this May 5, 2017
Trott pushed a commit to Trott/io.js that referenced this pull request May 5, 2017
@watson @Trott
doc: fix commit guideline url
4703824 
PR-URL: nodejs#12862
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@watson watson deleted the pr-tmpl branch May 6, 2017 07:59
anchnk pushed a commit to anchnk/node that referenced this pull request May 6, 2017
@watson
doc: fix commit guideline url
bea9ad0 
PR-URL: nodejs#12862
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@jasnell jasnell mentioned this pull request May 11, 2017
Closed
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Trott Trott Trott approved these changes

@Fishrock123 Fishrock123 Fishrock123 approved these changes

@lpinca lpinca lpinca approved these changes

@vsemozhetbyt vsemozhetbyt vsemozhetbyt approved these changes

Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@watson @vsemozhetbyt @Trott @Fishrock123 @lpinca @gibfahn @nodejs-github-bot