Skip to content

v4.x backport change https://github.com/nodejs/node/pull/12839 #13105

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

gabrielcsapo
Copy link

This is to backport #12839 to 4

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows [commit guidelines]

@nodejs-github-bot nodejs-github-bot added tls Issues and PRs related to the tls subsystem. v4.x labels May 18, 2017
@gabrielcsapo gabrielcsapo changed the title backport change https://github.com/nodejs/node/pull/12839 to 4 v4.x backport change https://github.com/nodejs/node/pull/12839 May 18, 2017
@mscdex
Copy link
Contributor

mscdex commented May 18, 2017

v4.x is in maintenance mode, so I don't think we are accepting feature additions anymore for that branch. /cc @nodejs/lts

@gabrielcsapo
Copy link
Author

:( okay, I will keep this open till someone closes it. I tried! :)

@gibfahn
Copy link
Member

gibfahn commented May 18, 2017

Thanks for the contribution @gabrielcsapo! Unfortunately as @mscdex says, v4.x has gone into maintenance mode so we are no longer backporting anything except critical security fixes.

If you're still interested in submitting a PR you could take a look at our good first contribution issues, or check out http://nodetodo.org/ if there's nothing suitable there (guide to contributing here). Mentoring is always available! If you need any help comment on here or elsewhere.

@gibfahn gibfahn closed this May 18, 2017
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
tls Issues and PRs related to the tls subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants