-
-
Notifications
You must be signed in to change notification settings - Fork 31.5k
readline: numeric strings converted to integers in cursorTo #13271
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
Why would we want to support this? I would consider passing non-number values to be an error. |
To make cursorTo easier to work with. A variable equal to a numeric string might be passed in by mistake. An error message for this case might be better though. |
I think throwing would be better than interpreting strings in this case. |
I'm not a big fan of this approach either. I'm +1 on just throwing a TypeError if the input is not a number already. |
I'll close this one since there are a lot of open pull requests |
Attempt to convert x and y in cursorTo to integers if they are not of type number
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
readline