deps: float patch on npm to fix citgm #13305
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
npm
cjihrig
approved these changes
May 30, 2017
|
FYI... @nodejs/ctc This is needed for the 8.0.0 release today and must be fast tracked. |
jasnell
approved these changes
May 30, 2017
|
@MylesBorins ... would you be able to kick off a quick citgm run on OSX to verify that this fixes the issue? |
evanlucas
approved these changes
May 30, 2017
|
@MylesBorins ... nevermind :-) ... I kicked one off https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/847/ |
This floats npm/npm#16791 onto npm v5.0.0 to fix an edge case that was found in citgm
|
I can verify that the patch fixes citgm on osx... tested on local machine |
jasnell
pushed a commit
that referenced
this pull request
May 30, 2017
This floats npm/npm#16791 onto npm v5.0.0 to fix an edge case that was found in citgm PR-URL: #13305 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
jasnell
pushed a commit
that referenced
this pull request
May 30, 2017
This floats npm/npm#16791 onto npm v5.0.0 to fix an edge case that was found in citgm PR-URL: #13305 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
|
landed in a85b48c |
|
This solves the |
3 tasks
|
Confirmed on |
|
@refack yeah... sorry for not documenting that |
3 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This floats npm/npm#16791 onto npm v5.0.0
to fix an edge case that was found in citgm
/cc @zkat