build: streamline JS test suites in Makefile #13340
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* alphabetize the JS test suites * Use CI_JS_SUITES variable instead of listing all tests
nodejs-github-bot
added
the
build
addaleax
approved these changes
May 31, 2017
cjihrig
approved these changes
May 31, 2017
richardlau
approved these changes
May 31, 2017
bnoordhuis
approved these changes
May 31, 2017
lpinca
approved these changes
Jun 1, 2017
gibfahn
approved these changes
Jun 1, 2017
jasnell
approved these changes
Jun 1, 2017
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Jun 2, 2017
* alphabetize the JS test suites * Use CI_JS_SUITES variable instead of listing all tests PR-URL: nodejs#13340 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 7b56fd8 |
|
Cross-ref: #13378 |
4 tasks
jasnell
pushed a commit
that referenced
this pull request
Jun 5, 2017
* alphabetize the JS test suites * Use CI_JS_SUITES variable instead of listing all tests PR-URL: #13340 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Closed
refack
added a commit
to refack/node
that referenced
this pull request
Jun 10, 2017
PR-URL: nodejs#13378 Refs: nodejs#13340 Refs: nodejs#13336 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Andreas Madsen <amwebdk@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com>
3 tasks
|
This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace do-not-land if it is being backported |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
build