url, i18n: update IDNA handling #13362
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
refack
reviewed
Jun 1, 2017
| if (mode == IDNA_STRICT) { | ||
| options |= UIDNA_USE_STD3_RULES; // UseSTD3ASCIIRules = beStrict | ||
| // VerifyDnsLength = beStrict; | ||
| // handled later |
There was a problem hiding this comment.
nit: align white space in comment?
There was a problem hiding this comment.
It was intended to be a continuation of the previous line due to the line length lint rule, thus indented.
refack
approved these changes
Jun 1, 2017
| // names in the wild. As such, in the current UTS #46 draft (rev. 18) these | ||
| // checks are made optional depending on the CheckHyphens flag, which will be | ||
| // disabled in WHATWG URL's "domain to ASCII" algorithm soon. | ||
| // In UTS #46 which specifies ToASCII, certain error conditions are |
|
|
||
| MaybeStackBuffer<char> buf; | ||
| int32_t len = ToASCII(&buf, *val, val.length(), lenient); | ||
| int32_t len = ToASCII(&buf, *val, val.length(), mode); |
There was a problem hiding this comment.
[question] AFAICT this is the only call to the workhorse ToASCII, so why implement IDNA_STRICT? Future proofing?
There was a problem hiding this comment.
So since it's not exposed maybe add a test case for IDNA_STRICT in test/cctest/test_url.cc
There was a problem hiding this comment.
The strict mode corresponds to beStrict variable in the algorithm. I'll make a mention of this in the code.
There was a problem hiding this comment.
[follow up]so in the current implementation IDNA_STRICT exists only in the sense that !IDNA_STRICT <=> IDNA_DEFAULT || IDNA_LENIENT?
|
LGTM |
watilde
approved these changes
Jun 1, 2017
jasnell
approved these changes
Jun 1, 2017
|
Rebased, @refack's comment addressed. The upstream PRs were landed so this should be good to go. |
|
Redundant test cases removed. One last CI: |
Remove custom tests for invalid IDNA domains in url-idna.js in favor of the more comprehensive official set. Refs: whatwg/url#309 Refs: web-platform-tests/wpt#5976
|
Landed in 91a1bbe. |
TimothyGu
added a commit
to TimothyGu/node
that referenced
this pull request
Jun 7, 2017
Remove custom tests for invalid IDNA domains in url-idna.js in favor of the more comprehensive official set. PR-URL: nodejs#13362 Refs: whatwg/url#309 Refs: web-platform-tests/wpt#5976 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Jun 7, 2017
Remove custom tests for invalid IDNA domains in url-idna.js in favor of the more comprehensive official set. PR-URL: #13362 Refs: whatwg/url#309 Refs: web-platform-tests/wpt#5976 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
3 tasks
|
This does not land cleanly in LTS. Please feel free to manually backport. Please also feel free to replace do-not-land if it is being backported |
|
dont-land is okay for this one, as the WHATWG URL parser is not in v6.x. |
TimothyGu
added a commit
to TimothyGu/node
that referenced
this pull request
Nov 28, 2017
Remove custom tests for invalid IDNA domains in url-idna.js in favor of the more comprehensive official set. PR-URL: nodejs#13362 Refs: whatwg/url#309 Refs: web-platform-tests/wpt#5976 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 18, 2018
Remove custom tests for invalid IDNA domains in url-idna.js in favor of the more comprehensive official set. Backport-PR-URL: #17365 PR-URL: #13362 Refs: whatwg/url#309 Refs: web-platform-tests/wpt#5976 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Feb 11, 2018
Remove custom tests for invalid IDNA domains in url-idna.js in favor of the more comprehensive official set. Backport-PR-URL: #17365 PR-URL: #13362 Refs: whatwg/url#309 Refs: web-platform-tests/wpt#5976 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 12, 2018
Remove custom tests for invalid IDNA domains in url-idna.js in favor of the more comprehensive official set. Backport-PR-URL: #17365 PR-URL: #13362 Refs: whatwg/url#309 Refs: web-platform-tests/wpt#5976 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 13, 2018
Remove custom tests for invalid IDNA domains in url-idna.js in favor of the more comprehensive official set. Backport-PR-URL: #17365 PR-URL: #13362 Refs: whatwg/url#309 Refs: web-platform-tests/wpt#5976 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PR is still somewhat of a WIP, as a proof-of-concept that the proposed changes to the URL Standard work (whatwg/url#309).
Refs: whatwg/url#309
Refs: web-platform-tests/wpt#5976
/cc @domenic @zimbabao
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
url