doc: use prefer-rest-params eslint rule in docs #13389
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
watilde
approved these changes
Jun 2, 2017
Do not promote using of `arguments`. One fragment is left as is because of history nature: it uses a real deprecated code from libs. Refs: http://eslint.org/docs/rules/prefer-rest-params Refs: https://github.com/nodejs/node/blob/99da8e8e02a874a0a044889f863c45700509d02c/lib/util.js#L1002-L1006
|
Added New linter CI: https://ci.nodejs.org/job/node-test-linter/9545/ |
cjihrig
approved these changes
Jun 2, 2017
jasnell
reviewed
Jun 2, 2017
| @@ -55,6 +55,7 @@ added: v0.8.0 | |||
| The `util.deprecate()` method wraps the given `function` or class in such a way that | |||
| it is marked as deprecated. | |||
|
|
|||
| <!-- eslint-disable prefer-rest-params --> | |||
There was a problem hiding this comment.
does this need a matching eslint-enable after the code block?
There was a problem hiding this comment.
If I get this right, these comments should relate only to the following block:
https://github.com/eslint/eslint-plugin-markdown#configuration-comments
There are some issues though:
I hope this will be fixed soon.
lpinca
approved these changes
Jun 3, 2017
jasnell
approved these changes
Jun 4, 2017
refack
approved these changes
Jun 4, 2017
|
Landed in ce8bce4 |
vsemozhetbyt
added a commit
that referenced
this pull request
Jun 5, 2017
Do not promote using of `arguments`. One fragment is left as is because of history nature: it uses a real deprecated code from libs. Refs: http://eslint.org/docs/rules/prefer-rest-params Refs: https://github.com/nodejs/node/blob/99da8e8e02a874a0a044889f863c45700509d02c/lib/util.js#L1002-L1006 PR-URL: #13389 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
jasnell
pushed a commit
that referenced
this pull request
Jun 5, 2017
Do not promote using of `arguments`. One fragment is left as is because of history nature: it uses a real deprecated code from libs. Refs: http://eslint.org/docs/rules/prefer-rest-params Refs: https://github.com/nodejs/node/blob/99da8e8e02a874a0a044889f863c45700509d02c/lib/util.js#L1002-L1006 PR-URL: #13389 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Closed
3 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc, tools
Do not promote using of
arguments.One fragment is left as is because of history nature: it uses a real deprecated code from libs.
Refs: http://eslint.org/docs/rules/prefer-rest-params
Refs:
node/lib/util.js
Lines 1002 to 1006 in 99da8e8