Skip to content

test: fix build warning in addons-napi\test_object #13412

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

test: fix build warning in addons-napi\test_object #13412

wants to merge 2 commits into from

Conversation

jasongin
Copy link
Member

@jasongin jasongin commented Jun 2, 2017

Fix a build warning in the test, reported at #13250 (comment)

Note this is plain C code, so C++ style casts cannot be used.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Jun 2, 2017
@jasongin
Copy link
Member Author

jasongin commented Jun 2, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/8447/

addaleax
addaleax approved these changes Jun 2, 2017
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but compare #12730 (comment) ;)

@jasongin
Copy link
Member Author

jasongin commented Jun 5, 2017

Pushed a commit to address feedback.

CI: https://ci.nodejs.org/job/node-test-pull-request/8487/

@jasongin
Copy link
Member Author

jasongin commented Jun 5, 2017

Landed as ddba969

@jasongin jasongin closed this Jun 5, 2017
jasongin added a commit that referenced this pull request Jun 5, 2017
@jasongin
test: fix build warning in addons-napi/test_object
ddba969 
PR-URL: #13412
Reviewed-By: Anna Henningsen <anna@addaleax.net>
jasnell pushed a commit that referenced this pull request Jun 7, 2017
@jasongin @jasnell
test: fix build warning in addons-napi/test_object
7be1a1c 
PR-URL: #13412
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@gibfahn gibfahn mentioned this pull request Jun 15, 2017
Closed
3 tasks
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 10, 2018
@jasongin
test: fix build warning in addons-napi/test_object
28cf8f0 
PR-URL: nodejs#13412
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
@jasongin @MylesBorins
test: fix build warning in addons-napi/test_object
eb42279 
Backport-PR-URL: #19447
PR-URL: #13412
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins mentioned this pull request Apr 16, 2018
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@addaleax addaleax addaleax approved these changes

Assignees
No one assigned
Labels
node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jasongin @addaleax @gibfahn @nodejs-github-bot