-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
test: add crypto check to test-tls-wrap-econnreset #13691
Conversation
Currently, there are a few test-tls-wrap-econnreset test that fail when Node is configured --without-ssl: Error: Node.js is not compiled with openssl crypto support This commit adds crypto checks and skips these tests if no crypto support unavailable.
@danbev is there a lint rule we could add for this? Something that says that if you |
@gibfahn I'll take a look if this can be added. I think it would also have to cover We talked about having a CI job for this, one that built using |
test/aix failure looks unrelatednot ok 13 async-hooks/test-fseventwrap
---
duration_ms: 0.185
severity: crashed
stack: |-
oh no!
exit code: CRASHED (Signal: 11) |
I need to do that (it's on my backlog), but a lint rule might be easier (it'd certainly catch things earlier). I'd want to see what other people think about having such a lint rule first though. cc/ @seishun @Trott @not-an-aardvark @mscdex |
AIX failure is indeed unrelated, see #13577 |
Currently, there are a few test-tls-wrap-econnreset test that fail when Node is configured --without-ssl: Error: Node.js is not compiled with openssl crypto support This commit adds crypto checks and skips these tests if no crypto support unavailable. PR-URL: nodejs#13691 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Landed in 7bdb5ca |
Currently, there are a few test-tls-wrap-econnreset test that fail when Node is configured --without-ssl: Error: Node.js is not compiled with openssl crypto support This commit adds crypto checks and skips these tests if no crypto support unavailable. PR-URL: #13691 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Currently, there are a few test-tls-wrap-econnreset test that fail when Node is configured --without-ssl: Error: Node.js is not compiled with openssl crypto support This commit adds crypto checks and skips these tests if no crypto support unavailable. PR-URL: #13691 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Currently, there are a few test-tls-wrap-econnreset test that fail when Node is configured --without-ssl: Error: Node.js is not compiled with openssl crypto support This commit adds crypto checks and skips these tests if no crypto support unavailable. PR-URL: #13691 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Currently, there are a few test-tls-wrap-econnreset test that fail when Node is configured --without-ssl: Error: Node.js is not compiled with openssl crypto support This commit adds crypto checks and skips these tests if no crypto support unavailable. PR-URL: #13691 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Currently, there are a few test-tls-wrap-econnreset test that fail when Node is configured --without-ssl: Error: Node.js is not compiled with openssl crypto support This commit adds crypto checks and skips these tests if no crypto support unavailable. PR-URL: #13691 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Currently, there are a few test-tls-wrap-econnreset test that fail when Node is configured --without-ssl: Error: Node.js is not compiled with openssl crypto support This commit adds crypto checks and skips these tests if no crypto support unavailable. PR-URL: #13691 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Currently, there are a few test-tls-wrap-econnreset test that fail when Node is configured --without-ssl: Error: Node.js is not compiled with openssl crypto support This commit adds crypto checks and skips these tests if no crypto support unavailable. PR-URL: #13691 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Currently, there are a few test-tls-wrap-econnreset test that fail when
Node is configured
--without-ssl
:Error: Node.js is not compiled with openssl crypto support
This commit adds crypto checks and skips these tests if no crypto
support unavailable.
Checklist
make -j4 test
(UNIX), orvcbuild test
(Windows) passesAffected core subsystem(s)
test