test: add check on an addon that doesn't register #13954

ezequielgarcia · 2017-06-28T02:35:27Z

This test require()s a shared library that won't register as a node module.

Other tests would be possible such as loading a file that is not a shared library, or loading a path that doesn't exist. However, these two tests produce platform-dependent error messages, and so I haven't included them.

Checklist

make -j4 test (UNIX) passes
commit message follows commit guidelines

Affected core subsystem(s)

test

cjihrig · 2017-06-28T12:49:43Z

test/addons/not-a-binding/test.js

+const common = require('../../common');
+const assert = require('assert');
+
+const re = new RegExp('Module did not self-register');


Can you use ^ and $ to make sure the entire error message is being matched.

@cjihrig done.

bnoordhuis

LGTM. CI: https://ci.nodejs.org/job/node-test-pull-request/8864/

bnoordhuis · 2017-06-29T12:26:17Z

test/addons/not-a-binding/test.js

+const assert = require('assert');
+
+const re = new RegExp('^Error: Module did not self-register\\.$');
+assert.throws(() => require(`./build/${common.buildType}/binding`), re);


Out of curiosity, what is the reason for using a regexp object instead of a regexp literal?

No reason, just that I used the node-module-version test as model.

I'd generally prefer the regexp literal form.

This commit calls require on a shared library that is not declared as a node module, and therefore does not register properly. Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>

ezequielgarcia · 2017-06-30T16:10:40Z

Agreed. Changed to literal.

mhdawson

LGTM

jasnell · 2017-07-10T15:45:39Z

CI: https://ci.nodejs.org/job/node-test-pull-request/9063/

jasnell · 2017-07-10T16:06:28Z

Looks like there are linting issues that need to be fixed.

ezequielgarcia · 2017-07-10T16:33:03Z

@jasnell I don't have read permissions, my user is ezequielgarcia. I'll run the linter and update.

jasnell · 2017-07-10T17:10:46Z

Access to the CI environment is temporarily blocked while testing a number of security fixes.

gibfahn · 2017-07-11T23:46:19Z

@jasnell I don't have read permissions, my user is ezequielgarcia. I'll run the linter and update.

Try now 😁

ezequielgarcia · 2017-07-12T19:53:10Z

@jasnell according to https://ci.nodejs.org/job/node-test-linter/10386/console, there was some git errors...

git fetch --tags --progress https://github.com/nodejs/node.git +refs/heads/:refs/remotes/origin/ +refs/pull/13954/head:refs/remotes/origin/_jenkins_local_branch # timeout=20
ERROR: Error fetching remote repo 'origin'

or am I looking the wrong place?

gibfahn · 2017-07-13T03:51:41Z

@ezequielgarcia that one looks like a transient issue, rerunning:

CI 2: https://ci.nodejs.org/job/node-test-commit/11092/

tniessen · 2017-08-01T10:42:41Z

Pre-land CI: https://ci.nodejs.org/job/node-test-pull-request/9432/

Assuming there are no objections from @bnoordhuis @jasnell @cjihrig @mhdawson ... ?

bnoordhuis · 2017-08-01T10:53:07Z

No objections, still LGTM.

refack · 2017-08-01T12:17:27Z

centos fail is most probably unrelated - opened #14568

jasnell · 2017-08-01T14:49:06Z

still lgtm

tniessen · 2017-08-01T15:46:21Z

Landed in 13d6eae, thank you!

This commit calls require on a shared library that is not declared as a node module, and therefore does not register properly. PR-URL: #13954 Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>

nodejs-github-bot added addons Issues and PRs related to native addons. test Issues and PRs related to the tests. labels Jun 28, 2017

cjihrig reviewed Jun 28, 2017

View reviewed changes

ezequielgarcia force-pushed the test_not_a_binding branch from e3fd9ca to 1a5b353 Compare June 29, 2017 02:35

bnoordhuis approved these changes Jun 29, 2017

View reviewed changes

cjihrig approved these changes Jun 30, 2017

View reviewed changes

jasnell approved these changes Jun 30, 2017

View reviewed changes

test: add check on an addon that doesn't register

1db7836

This commit calls require on a shared library that is not declared as a node module, and therefore does not register properly. Signed-off-by: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>

ezequielgarcia force-pushed the test_not_a_binding branch from 1a5b353 to 1db7836 Compare June 30, 2017 16:09

mhdawson approved these changes Jul 6, 2017

View reviewed changes

tniessen approved these changes Aug 1, 2017

View reviewed changes

tniessen self-assigned this Aug 1, 2017

tniessen closed this Aug 1, 2017

addaleax mentioned this pull request Aug 2, 2017

v8.3.0 proposal #14594

Merged

MylesBorins added the land-on-v6.x label Aug 16, 2017

MylesBorins mentioned this pull request Aug 16, 2017

v6.11.3-proposal #14852

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

test: add check on an addon that doesn't register #13954

test: add check on an addon that doesn't register #13954

ezequielgarcia commented Jun 28, 2017 •

edited

Loading

cjihrig Jun 28, 2017

ezequielgarcia Jun 29, 2017

bnoordhuis left a comment

bnoordhuis Jun 29, 2017

ezequielgarcia Jun 30, 2017

jasnell Jun 30, 2017

ezequielgarcia commented Jun 30, 2017

mhdawson left a comment

jasnell commented Jul 10, 2017

jasnell commented Jul 10, 2017

ezequielgarcia commented Jul 10, 2017 •

edited

Loading

jasnell commented Jul 10, 2017

gibfahn commented Jul 11, 2017

ezequielgarcia commented Jul 12, 2017

gibfahn commented Jul 13, 2017

tniessen commented Aug 1, 2017

bnoordhuis commented Aug 1, 2017

refack commented Aug 1, 2017

jasnell commented Aug 1, 2017

tniessen commented Aug 1, 2017

test: add check on an addon that doesn't register #13954

test: add check on an addon that doesn't register #13954

Conversation

ezequielgarcia commented Jun 28, 2017 • edited Loading

Checklist

Affected core subsystem(s)

cjihrig Jun 28, 2017

Choose a reason for hiding this comment

ezequielgarcia Jun 29, 2017

Choose a reason for hiding this comment

bnoordhuis left a comment

Choose a reason for hiding this comment

bnoordhuis Jun 29, 2017

Choose a reason for hiding this comment

ezequielgarcia Jun 30, 2017

Choose a reason for hiding this comment

jasnell Jun 30, 2017

Choose a reason for hiding this comment

ezequielgarcia commented Jun 30, 2017

mhdawson left a comment

Choose a reason for hiding this comment

jasnell commented Jul 10, 2017

jasnell commented Jul 10, 2017

ezequielgarcia commented Jul 10, 2017 • edited Loading

jasnell commented Jul 10, 2017

gibfahn commented Jul 11, 2017

ezequielgarcia commented Jul 12, 2017

gibfahn commented Jul 13, 2017

tniessen commented Aug 1, 2017

bnoordhuis commented Aug 1, 2017

refack commented Aug 1, 2017

jasnell commented Aug 1, 2017

tniessen commented Aug 1, 2017

ezequielgarcia commented Jun 28, 2017 •

edited

Loading

ezequielgarcia commented Jul 10, 2017 •

edited

Loading