Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[js-confcn]replace string concatenation with template literals #14269

Closed
wants to merge 2 commits into from
Closed

[js-confcn]replace string concatenation with template literals #14269

wants to merge 2 commits into from

Conversation

4garfield
Copy link
Contributor

@4garfield 4garfield commented Jul 16, 2017 •
edited
Loading

replace the string concation at test/addons-napi/test_reference/test.js

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

@4garfield
replace string concatenation with template literals
3f2b125 
replace the string concation at test/addons-napi/test_reference/test.js
@nodejs-github-bot nodejs-github-bot added node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests. labels Jul 16, 2017
@joyeecheung joyeecheung added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Jul 16, 2017
Trott
Trott approved these changes Jul 16, 2017
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green.

@joyeecheung
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/9143/

@TimothyGu TimothyGu added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. and removed code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. labels Jul 16, 2017
@4garfield
test: replace string concatenation
785b0d9 
replace string-concation in test/async-hooks/test-signalwrap.js with template literals
@targos
Copy link
Member

targos commented Jul 16, 2017

The change in test-signalwrap is in conflict with #14295

@vsemozhetbyt vsemozhetbyt marked this as a duplicate of #14295 Jul 16, 2017
@vsemozhetbyt vsemozhetbyt mentioned this pull request Jul 16, 2017
Closed
4 tasks
Trott pushed a commit to Trott/io.js that referenced this pull request Jul 16, 2017
@4garfield @Trott
test: replace string concat with template literal
e3f7a54 
Replace the string concat at test/addons-napi/test_reference/test.js.

PR-URL: nodejs#14269
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott
Copy link
Member

Trott commented Jul 16, 2017

Landed the first commit in e3f7a54. (The second commit is in a different PR and is unrelated, so I won't land it here.)

Thanks for the contribution! 🎉

@Trott Trott closed this Jul 16, 2017
@addaleax addaleax mentioned this pull request Jul 18, 2017
Merged
addaleax pushed a commit that referenced this pull request Jul 18, 2017
@4garfield @addaleax
test: replace string concat with template literal
c8087c0 
Replace the string concat at test/addons-napi/test_reference/test.js.

PR-URL: #14269
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Fishrock123 pushed a commit that referenced this pull request Jul 19, 2017
@4garfield @Fishrock123
test: replace string concat with template literal
253e4d0 
Replace the string concat at test/addons-napi/test_reference/test.js.

PR-URL: #14269
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 10, 2018
@4garfield
test: replace string concat with template literal
bc83e71 
Replace the string concat at test/addons-napi/test_reference/test.js.

PR-URL: nodejs#14269
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
@4garfield @MylesBorins
test: replace string concat with template literal
3f3eaf9 
Replace the string concat at test/addons-napi/test_reference/test.js.

Backport-PR-URL: #19447
PR-URL: #14269
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 16, 2018
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Trott Trott Trott approved these changes

@cjihrig cjihrig cjihrig approved these changes

@joyeecheung joyeecheung joyeecheung approved these changes

Assignees
No one assigned
Labels
code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. node-api Issues and PRs related to the Node-API. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@4garfield @joyeecheung @targos @Trott @cjihrig @MylesBorins @TimothyGu @nodejs-github-bot