Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

replacc string concatenation in test/parallel/test-https-unix-socket-… #14282

Closed
wants to merge 1 commit into from
Closed

replacc string concatenation in test/parallel/test-https-unix-socket-… #14282

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/parallel/test-https-unix-socket-self-signed.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@ common.refreshTmpDir();
const fs = require('fs');
const https = require('https');
const options = {
cert: fs.readFileSync(common.fixturesDir + '/test_cert.pem'),
key: fs.readFileSync(common.fixturesDir + '/test_key.pem')
cert: fs.readFileSync(`${common.fixturesDir}/test_cert.pem`),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zyziyun Would you consider altering these to use path.join() instead? For example:

  cert: fs.readFileSync(path.join(common.fixturesDir, 'test_cert.pem'),

key: fs.readFileSync(`${common.fixturesDir}/test_key.pem`)
};

const server = https.createServer(options, common.mustCall((req, res) => {
Expand Down