Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

url: significantly improve the performance of the url module #1561

Closed
wants to merge 1 commit into from
Closed

url: significantly improve the performance of the url module #1561

wants to merge 1 commit into from

Conversation

petkaantonov
Copy link
Contributor

New PR to target master

This was referenced Apr 29, 2015
Closed
Closed
@petkaantonov petkaantonov added the semver-major PRs that contain breaking changes and should be released in the next major version. label Apr 29, 2015
@petkaantonov petkaantonov added this to the 2.0.0 milestone Apr 29, 2015
@Fishrock123
Copy link
Contributor

CI: https://jenkins-iojs.nodesource.com/view/iojs/job/iojs+any-pr+multi/636/

@piscisaureus
Copy link
Contributor

@petkaantonov Is this ready to land in your mind?

@petkaantonov
Copy link
Contributor Author

@piscisaureus yes although @domenic might want to check it out

@domenic
Copy link
Contributor

domenic commented Apr 29, 2015

LGTM!

@jbergstroem
Copy link
Member

Very happy about getting the WhatWG tests in. Great job both @petkaantonov and all diligent reviewers.

@Fishrock123
Copy link
Contributor

Original PR for posterity: #933

@domenic
Copy link
Contributor

domenic commented May 2, 2015

What is this waiting on before it can be merged? Nothing, right?

petkaantonov added a commit that referenced this pull request May 2, 2015
@petkaantonov @rvagg
url: significantly improve the performance of the url module
3fd7fc4 
(landed by @rvagg)

PR-URL: #1561
Reviewed-By: Domenic Denicola <domenic@domenicdenicola.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
@rvagg
Copy link
Member

rvagg commented May 2, 2015

took the liberty of landing this, I hope you don't mind @petkaantonov. 3fd7fc4

@rvagg rvagg closed this May 2, 2015
This was referenced May 2, 2015
Closed
Closed
@isaacs isaacs mentioned this pull request May 3, 2015
Merged
@othiym23 othiym23 mentioned this pull request May 5, 2015
Closed
@Fishrock123 Fishrock123 mentioned this pull request Jun 10, 2015
Closed
@Fishrock123 Fishrock123 mentioned this pull request Jul 30, 2015
Closed
@STRML STRML mentioned this pull request Aug 5, 2015
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
2.0.0
Development

Successfully merging this pull request may close these issues.
6 participants
@petkaantonov @Fishrock123 @piscisaureus @domenic @jbergstroem @rvagg