Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

n-api: check against invalid handle scope usage #16201

Closed
wants to merge 1 commit into from
Closed

n-api: check against invalid handle scope usage #16201

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

Fixes: #16175

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

n-api

@addaleax addaleax added the node-api Issues and PRs related to the Node-API. label Oct 14, 2017
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Oct 14, 2017
@addaleax
Copy link
Member Author

@nodejs/n-api

@joyeecheung
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/10745/

mhdawson
mhdawson approved these changes Oct 16, 2017
View reviewed changes
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mhdawson
Copy link
Member

CI run: https://ci.nodejs.org/job/node-test-pull-request/10758/console

@addaleax
Copy link
Member Author

Landed in b3f9b38

@addaleax addaleax closed this Oct 18, 2017
@addaleax addaleax deleted the napi-handlescopes branch October 18, 2017 09:36
addaleax added a commit that referenced this pull request Oct 18, 2017
@addaleax
n-api: check against invalid handle scope usage
b3f9b38 
Fixes: #16175
PR-URL: #16201
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax added a commit to ayojs/ayo that referenced this pull request Oct 18, 2017
@addaleax
n-api: check against invalid handle scope usage
fd8ca8f 
Fixes: nodejs/node#16175
PR-URL: nodejs/node#16201
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
targos pushed a commit that referenced this pull request Oct 18, 2017
@addaleax @targos
n-api: check against invalid handle scope usage
0a52479 
Fixes: #16175
PR-URL: #16201
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@RReverser
Copy link
Member

RReverser commented Nov 12, 2017 •
edited
Loading

(Moved to its own issue: #16973)

@RReverser RReverser mentioned this pull request Nov 12, 2017
Closed
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Apr 16, 2018
@addaleax
n-api: check against invalid handle scope usage
96d1334 
Fixes: nodejs#16175
PR-URL: nodejs#16201
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 16, 2018
@addaleax @MylesBorins
n-api: check against invalid handle scope usage
55aab6b 
Fixes: #16175
Backport-PR-URL: #19447
PR-URL: #16201
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 16, 2018
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@jasnell jasnell jasnell approved these changes

@cjihrig cjihrig cjihrig approved these changes

@mhdawson mhdawson mhdawson approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@addaleax @joyeecheung @mhdawson @RReverser @bnoordhuis @jasnell @cjihrig @MylesBorins @nodejs-github-bot