doc: http2.connect accepts net & tls options #16576
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
approved these changes
Oct 28, 2017
cjihrig
approved these changes
Oct 29, 2017
| @@ -1627,6 +1627,7 @@ added: v8.4.0 | |||
| * `createConnection` {Function} An optional callback that receives the `URL` | |||
| instance passed to `connect` and the `options` object, and returns any | |||
| [`Duplex`][] stream that is to be used as the connection for this session. | |||
| * ...: Any [`net.connect()`][] or [`tls.connect()`][] options can be provided. | |||
There was a problem hiding this comment.
Can you add backticks to the ....
There was a problem hiding this comment.
The current version matches doc/api/tls.md where it's used like this 3 times. (Also one other place in the http2 doc.)
daxlab
approved these changes
Oct 29, 2017
|
I assume this doesn't need 48 hours but please speak up if you disagree. Will be merging within the next hour. |
jasnell
approved these changes
Oct 29, 2017
|
Landed in 8a9be41 |
Merged
Qard
pushed a commit
to ayojs/ayo
that referenced
this pull request
Nov 2, 2017
PR-URL: nodejs/node#16576 Fixes: nodejs/node#15405 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Qard
pushed a commit
to ayojs/ayo
that referenced
this pull request
Nov 2, 2017
PR-URL: nodejs/node#16576 Fixes: nodejs/node#15405 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax
pushed a commit
to ayojs/ayo
that referenced
this pull request
Dec 7, 2017
PR-URL: nodejs/node#16576 Fixes: nodejs/node#15405 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it clear that
http2.connectcan accept all the same options asnet.connectandtls.connectsince there seems to be some confusion around this.Fixes: #15405
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
doc