Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

src: use unique_ptr for http2_state #17078

Closed
wants to merge 1 commit into from
Closed

src: use unique_ptr for http2_state #17078

wants to merge 1 commit into from

Conversation

fhinkel
Copy link
Member

@fhinkel fhinkel commented Nov 16, 2017

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

src

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Nov 16, 2017
@fhinkel fhinkel requested a review from addaleax November 19, 2017 08:40
@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 19, 2017
@addaleax
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-commit/14139/

@addaleax
Copy link
Member

https://ci.nodejs.org/job/node-test-commit-linux/nodes=ubuntu1710-x64/14240/console says:

In file included from ../src/inspector_agent.h:13:0,
                 from ../src/env.h:30,
                 from ../src/env-inl.h:28,
                 from ../src/base_object-inl.h:28,
                 from ../src/async_wrap-inl.h:28,
                 from ../src/async_wrap.cc:22:
../src/node_platform.h:81:45: error: ‘function’ is not a member of ‘std’
   typedef std::unique_ptr<DelayedTask, std::function<void(DelayedTask*)>>
                                             ^~~~~~~~
../src/node_platform.h:81:45: note: suggested alternative: ‘is_function’
   typedef std::unique_ptr<DelayedTask, std::function<void(DelayedTask*)>>
                                             ^~~~~~~~
                                             is_function
../src/node_platform.h:81:45: error: ‘function’ is not a member of ‘std’
../src/node_platform.h:81:45: note: suggested alternative: ‘is_function’
   typedef std::unique_ptr<DelayedTask, std::function<void(DelayedTask*)>>
                                             ^~~~~~~~
                                             is_function
../src/node_platform.h:81:72: error: template argument 2 is invalid
   typedef std::unique_ptr<DelayedTask, std::function<void(DelayedTask*)>>
                                                                        ^~
node.target.mk:202: recipe for target '/home/iojs/build/workspace/node-test-commit-linux/nodes/ubuntu1710-x64/out/Release/obj.target/node/src/async_wrap.o' failed

@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 19, 2017
@fhinkel
Copy link
Member Author

fhinkel commented Nov 19, 2017

Thanks for running the CI and spotting the error. Looks like -std=c++0x is missing. I'll look into it.

@addaleax
Copy link
Member

@fhinkel I’d guess it’s just a missing #include?

@addaleax
Copy link
Member

New CI: https://ci.nodejs.org/job/node-test-commit/14144/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 19, 2017
@addaleax
Copy link
Member

Landed in 2d50b5e

@addaleax addaleax closed this Nov 19, 2017
addaleax pushed a commit that referenced this pull request Nov 19, 2017
@fhinkel @addaleax
src: use unique_ptr for http2_state
2d50b5e 
PR-URL: #17078
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 28, 2017
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@fhinkel @MylesBorins
src: use unique_ptr for http2_state
60423f5 
PR-URL: #17078
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 19, 2017
@fhinkel @gibfahn
src: use unique_ptr for http2_state
ad5f2d2 
PR-URL: #17078
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@fhinkel @gibfahn
src: use unique_ptr for http2_state
f12efd5 
PR-URL: #17078
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@fhinkel @addaleax @cjihrig @MylesBorins @gibfahn @nodejs-github-bot