test: use common.crashOnUnhandledRejection #17233
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MylesBorins
suggested changes
Nov 22, 2017
| @@ -1,5 +1,6 @@ | |||
| 'use strict'; | |||
| const common = require('../common'); | |||
| common.crashOnUnhandledRejection(); | |||
There was a problem hiding this comment.
Can you please move this to line 7 below all the require statements
There was a problem hiding this comment.
@MylesBorins I have moved this to line 7, thanks to review.
|
@MylesBorins - are these |
gireeshpunathil
added
the
code-and-learn
jasnell
approved these changes
Nov 22, 2017
There was a problem hiding this comment.
LGTM with @MylesBorins' comment addressed (which can be done on landing fwiw)
|
Landed in 317f596 |
MylesBorins
pushed a commit
that referenced
this pull request
Nov 23, 2017
PR-URL: #17233 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17233 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
PR-URL: #17233 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Dec 19, 2017
PR-URL: #17233 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
gibfahn
pushed a commit
that referenced
this pull request
Dec 19, 2017
PR-URL: #17233 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
PR-URL: #17233 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add
common.crashOnUnhandledRejection()totest/parallel/test-repl-load-multiline.jsChecklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test