test: fix flaky test-benchmark-querystring #17517
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow zero iterations for short benchmark in test.
Trott
added
benchmark
|
Sample failure in CI: 19:51:11 not ok 154 parallel/test-benchmark-querystring
19:51:11 ---
19:51:11 duration_ms: 1.353
19:51:11 severity: fail
19:51:11 stack: |-
19:51:11
19:51:11 querystring/querystring-parse.js
19:51:11 /home/iojs/build/workspace/node-test-commit-linux-linked/nodes/ubuntu1604_sharedlibs_fips20_x64/benchmark/common.js:202
19:51:11 throw new Error('insufficient clock precision for short benchmark');
19:51:11 ^
19:51:11
19:51:11 Error: insufficient clock precision for short benchmark
19:51:11 at Benchmark.end (/home/iojs/build/workspace/node-test-commit-linux-linked/nodes/ubuntu1604_sharedlibs_fips20_x64/benchmark/common.js:202:13)
19:51:11 at main (/home/iojs/build/workspace/node-test-commit-linux-linked/nodes/ubuntu1604_sharedlibs_fips20_x64/benchmark/querystring/querystring-parse.js:33:11)
19:51:11 at Benchmark.process.nextTick (/home/iojs/build/workspace/node-test-commit-linux-linked/nodes/ubuntu1604_sharedlibs_fips20_x64/benchmark/common.js:34:28)
19:51:11 at process._tickCallback (internal/process/next_tick.js:150:11)
19:51:11 at Function.Module.runMain (module.js:703:11)
19:51:11 at startup (bootstrap_node.js:195:16)
19:51:11 at bootstrap_node.js:646:3
19:51:11 assert.js:42
19:51:11 throw new errors.AssertionError({
19:51:11 ^
19:51:11
19:51:11 AssertionError [ERR_ASSERTION]: 1 strictEqual 0
19:51:11 at ChildProcess.child.on (/home/iojs/build/workspace/node-test-commit-linux-linked/nodes/ubuntu1604_sharedlibs_fips20_x64/test/common/benchmark.js:25:12)
19:51:11 at ChildProcess.emit (events.js:126:13)
19:51:11 at Process.ChildProcess._handle.onexit (internal/child_process.js:209:12)
19:51:11 ... |
|
CI: https://ci.nodejs.org/job/node-test-pull-request/11935/ [UPDATE: It's yellow.] |
apapirovski
approved these changes
Dec 7, 2017
cjihrig
approved these changes
Dec 7, 2017
evanlucas
approved these changes
Dec 8, 2017
refack
approved these changes
Dec 8, 2017
|
Once again you beat me to it... |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Dec 8, 2017
Allow zero iterations for short benchmark in test. PR-URL: nodejs#17517 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
|
Landed in 09e9e2b |
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
Allow zero iterations for short benchmark in test. PR-URL: #17517 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 12, 2017
Allow zero iterations for short benchmark in test. PR-URL: #17517 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
Allow zero iterations for short benchmark in test. PR-URL: #17517 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Closed
gibfahn
pushed a commit
that referenced
this pull request
Dec 20, 2017
Allow zero iterations for short benchmark in test. PR-URL: #17517 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow zero iterations for short benchmark in test.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test benchmark querystring