Skip to content

crypto: use SetNull instead of Set #17521

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

crypto: use SetNull instead of Set #17521

wants to merge 1 commit into from

Conversation

danbev
Copy link
Contributor

@danbev danbev commented Dec 7, 2017

This commit updates the only usage of Set(Null(env->isolate()) to use
SetNull() instead which is used in other places in node_crypto.cc.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

crypto

@danbev
crypto: use SetNull instead of Set
932aceb 
This commit updates the only usage of Set(Null(env->isolate()) to use
SetNull() instead which is used in other places in node_crypto.cc.
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. labels Dec 7, 2017
@danbev
Copy link
Contributor Author

danbev commented Dec 7, 2017

CI: https://ci.nodejs.org/job/node-test-pull-request/11938/

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 7, 2017
@addaleax
Copy link
Member

addaleax commented Dec 7, 2017

Landed in 0bc10b0

@addaleax addaleax closed this Dec 7, 2017
@addaleax addaleax removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 7, 2017
addaleax pushed a commit that referenced this pull request Dec 7, 2017
@danbev @addaleax
crypto: use SetNull instead of Set
0bc10b0 
This commit updates the only usage of Set(Null(env->isolate()) to use
SetNull() instead which is used in other places in node_crypto.cc.

PR-URL: #17521
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@danbev @MylesBorins
crypto: use SetNull instead of Set
abafdae 
This commit updates the only usage of Set(Null(env->isolate()) to use
SetNull() instead which is used in other places in node_crypto.cc.

PR-URL: #17521
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
MylesBorins pushed a commit that referenced this pull request Dec 12, 2017
@danbev @MylesBorins
crypto: use SetNull instead of Set
9e50f17 
This commit updates the only usage of Set(Null(env->isolate()) to use
SetNull() instead which is used in other places in node_crypto.cc.

PR-URL: #17521
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@MylesBorins MylesBorins mentioned this pull request Dec 12, 2017
Merged
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@danbev @gibfahn
crypto: use SetNull instead of Set
b563908 
This commit updates the only usage of Set(Null(env->isolate()) to use
SetNull() instead which is used in other places in node_crypto.cc.

PR-URL: #17521
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@danbev @gibfahn
crypto: use SetNull instead of Set
befb163 
This commit updates the only usage of Set(Null(env->isolate()) to use
SetNull() instead which is used in other places in node_crypto.cc.

PR-URL: #17521
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Closed
gibfahn pushed a commit that referenced this pull request Dec 20, 2017
@danbev @gibfahn
crypto: use SetNull instead of Set
54f6b29 
This commit updates the only usage of Set(Null(env->isolate()) to use
SetNull() instead which is used in other places in node_crypto.cc.

PR-URL: #17521
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
@gibfahn gibfahn mentioned this pull request Dec 20, 2017
Merged
@MylesBorins MylesBorins mentioned this pull request Dec 20, 2017
Merged
@danbev danbev deleted the crypto-set-null branch February 28, 2018 07:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@apapirovski apapirovski apapirovski approved these changes

@addaleax addaleax addaleax approved these changes

@cjihrig cjihrig cjihrig approved these changes

@tniessen tniessen tniessen approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@danbev @addaleax @apapirovski @cjihrig @tniessen @gibfahn @nodejs-github-bot